Fennec 49.0b1 multilocale step broken

RESOLVED FIXED

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: nthomas, Assigned: nthomas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

21:28:38     INFO - Running command: ['hg', '--config', 'ui.merge=internal:merge', '--config', 'extensions.robustcheckout=/builds/slave/rel-m-beta-and-x86_bld-0000000/mozharness/external_tools/robustcheckout.py', 'robustcheckout', u'https://hg.mozilla.org/build/buildbot-configs', u'build/configs', '--sharebase', u'/builds/hg-shared', '--revision', 'FENNEC_49_0b1_RELEASE']
21:28:38     INFO - Copy/paste: hg --config ui.merge=internal:merge --config extensions.robustcheckout=/builds/slave/rel-m-beta-and-x86_bld-0000000/mozharness/external_tools/robustcheckout.py robustcheckout https://hg.mozilla.org/build/buildbot-configs build/configs --sharebase /builds/hg-shared --revision FENNEC_49_0b1_RELEASE
21:28:39     INFO -  Traceback (most recent call last):
21:28:39     INFO -    File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/dispatch.py", line 191, in _runcatch
21:28:39     INFO -      return _dispatch(req)
21:28:39     INFO -    File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/dispatch.py", line 924, in _dispatch
21:28:39     INFO -      cmdpats, cmdoptions)
21:28:39     INFO -    File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/dispatch.py", line 681, in runcommand
21:28:39     INFO -      ret = _runcommand(ui, options, cmd, d)
21:28:39     INFO -    File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/dispatch.py", line 1055, in _runcommand
21:28:39     INFO -      return checkargs()
21:28:39     INFO -    File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/dispatch.py", line 1015, in checkargs
21:28:39     INFO -      return cmdfunc()
21:28:39     INFO -    File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/dispatch.py", line 921, in <lambda>
21:28:39     INFO -      d = lambda: util.checksignature(func)(ui, *args, **cmdoptions)
21:28:39     INFO -    File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/util.py", line 991, in check
21:28:39     INFO -      return func(*args, **kwargs)
21:28:39     INFO -    File "/builds/slave/rel-m-beta-and-x86_bld-0000000/mozharness/external_tools/robustcheckout.py", line 134, in robustcheckout
21:28:39     INFO -      raise error.Abort('--revision must be a SHA-1 fragment 12-40 '
21:28:39     INFO -  Abort: --revision must be a SHA-1 fragment 12-40 characters long
21:28:39     INFO -  abort: --revision must be a SHA-1 fragment 12-40 characters long

Which will be from robustcheckout making it to beta in 49, and hitting https://dxr.mozilla.org/mozilla-beta/rev/f21e48559ecda2e225953d4dffef3127cd903ba7/testing/mozharness/external_tools/robustcheckout.py#131
We're only using --tag-override for releases
  https://dxr.mozilla.org/build-central/search?q=tag-override&redirect=true
  https://dxr.mozilla.org/mozilla-beta/search?q=tag-override&redirect=true
Any bustage in the multilocale nightly builds is long since settled, eg bug 1275623.

So I think this should be pretty safe to change, even though it's in vcsbase.py.
Attachment #8777185 - Flags: review?(rail)
Attachment #8777185 - Flags: review?(rail) → review+
Comment on attachment 8777185 [details] [diff] [review]
[gecko] Use branch instead of revision when passing out release tag

https://hg.mozilla.org/releases/mozilla-beta/rev/7a485f899de7
Attachment #8777185 - Flags: checked-in+
Pushed by nthomas@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35ba6de9c442
Fennec 49.0b1 multilocale step broken, r=rail
Still need to land to aurora, currently closed.
https://hg.mozilla.org/releases/mozilla-aurora/rev/495b385af8f0
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.