1291573 - Unified autocomplete/autofill "Visit" row should show the page title if it is in the history or bookmark

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P3)

Description

[Masatoshi Kimura [:emk]]

I'm often frustrated the absence of the page title after unified autocomplete has been introduced.

For example, when I type "bug" in the URL bar, the Action row is "bugzilla.mozilla.org - Visit". It should be something like "bugzilla.mozilla.org - Visit Bugzilla Main Page".

Comment 1

[Marco Bonardo [:mak]]

The first reason we don't show the title, is that in many cases we may not have it. The autoFill entry is generated on the fly, when we know the given domain is known to Places (but probably we only have title for a subpage).

The second reason is that this entry should come as fast as possible while the user is typing, we try to select the bare minimum for that to avoid delays.

that said it's something that could be evaluated, if it has a value from an UX point of view, we could look at the perf problem and see if it's acceptable to fetch a title WHEN we have a title.
On the other side, the right fix is likely bug 1235397, but it's not trivial to do.

Comment 2

[Masatoshi Kimura [:emk]]

(In reply to Marco Bonardo [::mak] (Away 6-20 Aug) from comment #1)
> The second reason is that this entry should come as fast as possible while
> the user is typing, we try to select the bare minimum for that to avoid
> delays.

It is OK for me to show the "Visit" row without the page title first, then add the page title when the query returns the result.

Comment 3

[Marco Bonardo [:mak]]

(In reply to Masatoshi Kimura [:emk] from comment #2)
> It is OK for me to show the "Visit" row without the page title first, then
> add the page title when the query returns the result.

that's hard to do for code architectural reasons.

Comment 5

[Drew Willcoxon :adw]

May be related to autofilling full URLs, not only origins, since currently autofill fills only origins. May also need UX input.

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: with-visit-label.png

I tried to show the title. I attached the screenshot.
I thought it looked a bit confusing, because the "Visit" label and the title got mixed.
Next, I will attach another screenshot without the Visit label.

Comment 7

[Daisuke Akatsuka (:daisuke)]

Attachment: without-visit.png

This one seems simpler and easier to understand at least for me.
What do you think? As Drew said, we may better ask UX team.

Comment 8

[Daisuke Akatsuka (:daisuke)]

But, if we choose the above, how about the page not visited yet.
Will we show "URL - Visit" as the same as now?
It may make confusion a bit since there may be pages whose title is “Visit”.

Comment 9

[Masatoshi Kimura [:emk]]

I prefer no "Visit" label.

Comment 10

[Drew Willcoxon :adw]

Thanks for testing these Daisuke. I agree with Masatoshi -- of the two options, without "Visit" is better. However, it's interesting because the screenshot in comment 7 shows the URL and title in the opposite places they usually are. Of course it makes sense because it's an autofill result, and autofill results show their URL first. But I wonder if it should be styled like a typical history result when a title is available.

So instead of this:

https://bugzilla.mozilla.org/ -- Bugzilla Main Page

Do this:

Bugzilla Main Page -- https://bugzilla.mozilla.org/

What do you think? Could you try that please and see how it looks? We should probably get Ryan's and/or Henry's opinion too.

Comment 11

[Daisuke Akatsuka (:daisuke)]

Attachment: title-first.png

Comment 12

[Daisuke Akatsuka (:daisuke)]

I attached a screenshot that shows the title first.
This also looks good!

One point of concern is when the URL has not yet been visited.
Perhaps the following suggestions could be chosen:

• http://bugzilla.mozilla.org/ - Visit (current implementation)
• http://bugzilla.mozilla.org/

In either case, the position that shows URL will be changed like Title - URL (visited) or URL - Visit (not visited yet).
There may be some discomfort with the change in location?

As you said, I'll ask Ryan as well.

Comment 13

[Ryan Casey]

(In reply to Daisuke Akatsuka (:daisuke) from comment #12)

I attached a screenshot that shows the title first.
This also looks good!

One point of concern is when the URL has not yet been visited.
Perhaps the following suggestions could be chosen:

• http://bugzilla.mozilla.org/ - Visit (current implementation)
• http://bugzilla.mozilla.org/

In either case, the position that shows URL will be changed like Title - URL (visited) or URL - Visit (not visited yet).
There may be some discomfort with the change in location?

As you said, I'll ask Ryan as well.

Thanks @Daisuke, some thoughts below:
I also like the latest iteration on order with "title" : "url-string"

• More consistent with suggestions below (Drew's point)
• I think the title is more "human" (more legible, easier to scan) than a URL
  In the case of a not yet visited URL - I think having the "-Visit" appended still makes sense as it offers context for the user as to the action to take/why they are being shown this URL. My concern otherwise is that without that context it could be confusing as to why it's shown, especially if a user has never visited said URL before.

I do think we should get Product (Henry) buy-in on this as well.

Comment 14

[Daisuke Akatsuka (:daisuke)]

Thank you very much for your clear answer, Ryan!
I'll ask Henry as well.

Hello Henry!
There is the idea that shows the page title for the autofill result row.
Could you please confirm the way to display the information?
Thanks!

Comment 15

[Henry Moseti]

(In reply to Daisuke Akatsuka (:daisuke) from comment #14)

Thank you very much for your clear answer, Ryan!
I'll ask Henry as well.

Hello Henry!
There is the idea that shows the page title for the autofill result row.
Could you please confirm the way to display the information?
Thanks!

I agree with the last agreed iteration with Ryan & Drew's input above. Also lets monitor feedback from users to measure the impact. Thanks.

Comment 16

[Daisuke Akatsuka (:daisuke)]

Thank you very much, Henry!
I will proceed with this.

Comment 17

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1291573: Show page title for autofill result.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f090ffdaf408
Show page title for autofill result. r=adw

Comment 19

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f090ffdaf408