Closed
Bug 1291633
Opened 8 years ago
Closed 8 years ago
Don't call MediaDecoder::SeekingStarted when visibility is Suppressed
Categories
(Core :: Audio/Video: Playback, defect, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
Details
Attachments
(1 file)
https://hg.mozilla.org/mozilla-central/file/6608e5864780589b25d5421c3d3673ab30c4c318/dom/media/MediaDecoder.cpp#l1314 It does nothing when visibility is Suppressed. We can choose not to send the event at all when visibility is Suppressed to save task dispatching to the main thread.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jwwang
Priority: -- → P3
|
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/69510/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69510/
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8778121 -
Flags: review?(kaku)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8778121 [details] Bug 1291633 - Don't call MediaDecoder::SeekingStarted when visibility is Suppressed. https://reviewboard.mozilla.org/r/69510/#review67000
Attachment #8778121 -
Flags: review?(kaku) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e566caff595 Don't call MediaDecoder::SeekingStarted when visibility is Suppressed. r=kaku
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3e566caff595
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•