refactor font-inflation reftests for input text

RESOLVED INVALID

Status

()

Core
Layout
RESOLVED INVALID
2 years ago
2 years ago

People

(Reporter: jeremychen, Assigned: jeremychen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

Created attachment 8777261 [details]
Bug 1291637 - remove input-text-*-height reftests.

input-text-*-height are exactly the same as input-text-*-height-ref, so these
reftests have been not functional for a while. Remove them.

Review commit: https://reviewboard.mozilla.org/r/68854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68854/
Attachment #8777261 - Flags: review?(dbaron)
Assignee: nobody → jeremychen
Status: NEW → ASSIGNED
Summary: refacor font-inflation reftests for input text → refactor font-inflation reftests for input text
Comment on attachment 8777261 [details]
Bug 1291637 - remove input-text-*-height reftests.

https://reviewboard.mozilla.org/r/68854/#review65936

These tests use test-pref(), which means they set different preferences for test and reference.  They're testing that the test running *with* font inflation produces the same results as the reference *without* font inflation.

You also didn't modify the reftest.list, so this patch would have turned the tree orange.
Attachment #8777261 - Flags: review?(dbaron) → review-
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID
(In reply to David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) from comment #2)
> Comment on attachment 8777261 [details]
> Bug 1291637 - remove input-text-*-height reftests.
> 
> https://reviewboard.mozilla.org/r/68854/#review65936
> 
> These tests use test-pref(), which means they set different preferences for
> test and reference.  They're testing that the test running *with* font
> inflation produces the same results as the reference *without* font
> inflation.
> 
> You also didn't modify the reftest.list, so this patch would have turned the
> tree orange.

Oops. Should've notice the test-pref() settings in the reftest.list. Thank you for the review.
Attachment #8777261 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.