Closed Bug 1291641 Opened 3 years ago Closed 3 years ago

Make the Pocket system add-on as e10s compatible

Categories

(Firefox :: Pocket, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

As part of the work to make sure that our system add-ons are all e10s compatible, we should make the Pocket system add-on compatible as well.

At the moment, it is probably using the shims to carry on working, but we should be moving away from those.
Shane: I think the changes here are all that is necessary. I couldn't see anything else other than the about code that might be using shims. I gave it few tests and it all seemed to work, but it'd be worth someone who knows the code checking it fully.
Assignee: nobody → standard8
Comment on attachment 8782434 [details]
Bug 1291641 - Make the Pocket system add-on as e10s compatible.

https://reviewboard.mozilla.org/r/72606/#review70306

This all looks good.
Attachment #8782434 - Flags: review?(mixedpuppy) → review+
I'm concerned about the pocket library files though [Pocket.jsm, main.js, pktApi.js], I wouldn't be certain this finishes e10s.
(In reply to Shane Caraveo (:mixedpuppy) from comment #4)
> I'm concerned about the pocket library files though [Pocket.jsm, main.js,
> pktApi.js], I wouldn't be certain this finishes e10s.

I've gone through those again and I believe they are currently fine wrt disabling the shims.

The pocket panel isn't currently remote enabled, and I suspect that wouldn't work if it was switch to the child process.
I updated the patch to remove a couple of lines of debug that I'd managed to leave in.
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e1fae5d48067
Make the Pocket system add-on as e10s compatible. r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/e1fae5d48067
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Depends on: 1355533
You need to log in before you can comment on or make changes to this bug.