Run web-platform-tests lint on CI

RESOLVED FIXED in Firefox 51

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jgraham, Unassigned)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
This should prevent us upstreaming changes that break the lint.
(Reporter)

Comment 1

2 years ago
Created attachment 8777366 [details]
Bug 1291735 - Enable wpt lint on ci,

Review commit: https://reviewboard.mozilla.org/r/68934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68934/
Attachment #8777366 - Flags: review?(ahalberstadt)
Attachment #8777367 - Flags: review?(Ms2ger)
Attachment #8777368 - Flags: review?(Ms2ger)
(Reporter)

Comment 3

2 years ago
Created attachment 8777368 [details]
Bug 1291735 - Lint all files under the wpt root, not just committed ones,

This removes the git dependency

Review commit: https://reviewboard.mozilla.org/r/68938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68938/
Attachment #8777367 - Flags: review?(Ms2ger) → review+
Comment on attachment 8777368 [details]
Bug 1291735 - Lint all files under the wpt root, not just committed ones,

https://reviewboard.mozilla.org/r/68938/#review66026
Attachment #8777368 - Flags: review?(Ms2ger) → review+
Comment on attachment 8777366 [details]
Bug 1291735 - Enable wpt lint on ci,

https://reviewboard.mozilla.org/r/68934/#review66034

::: taskcluster/ci/legacy/tasks/branches/base_jobs.yml:281
(Diff revision 1)
> +  wptlint-gecko:
> +    task: tasks/tests/mozlint-wpt.yml
> +    root: true
> +    when:
> +      file_patterns:
> +        - 'testing/web-platform/tests/**'

Please add python/mozlint, tools/lint and testing/docker/lint as well.

::: taskcluster/ci/legacy/tasks/tests/mozlint-wpt.yml:37
(Diff revision 1)
> +      tests: null
> +    treeherder:
> +      machine:
> +        platform: lint
> +      groupSymbol: tc
> +      symbol: Wl

I'm not a huge fan of this symbol because on treeherder it looks like WI instead of WL. Maybe 'WL' or even just 'wpt' (since it's already on the 'lint' platform, there's not really a need to clarify that it's a lint).
Attachment #8777366 - Flags: review?(ahalberstadt) → review+
(Reporter)

Comment 7

2 years ago
Comment on attachment 8777368 [details]
Bug 1291735 - Lint all files under the wpt root, not just committed ones,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68938/diff/1-2/
(Reporter)

Comment 8

2 years ago
Comment on attachment 8777367 [details]
Bug 1291735 - Fix wpt lint errors,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68936/diff/1-2/
(Reporter)

Comment 9

2 years ago
Comment on attachment 8777366 [details]
Bug 1291735 - Enable wpt lint on ci,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68934/diff/1-2/

Comment 10

2 years ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/fe7e2efb803f
Lint all files under the wpt root, not just committed ones, r=Ms2ger
https://hg.mozilla.org/integration/autoland/rev/f9825328b6b3
Fix wpt lint errors, r=Ms2ger
https://hg.mozilla.org/integration/autoland/rev/db87a086b693
Enable wpt lint on ci, r=ahal

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fe7e2efb803f
https://hg.mozilla.org/mozilla-central/rev/f9825328b6b3
https://hg.mozilla.org/mozilla-central/rev/db87a086b693
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.