Closed Bug 1291741 Opened 4 years ago Closed 4 years ago

Relax setTimeout throttling in background tabs when an AudioContext is present, rather than only when audio is playing

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: Nika, Assigned: Nika)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

See bug 1181073 comment 30 through 32 for an explanation as to why this may be necessary.
Attachment #8777901 - Flags: review?(bkelly) → review+
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc55edd1533d
Relax setTimeout throttling in background tabs when an AudioContext is present, rather than only when audio is playing, r=bkelly
https://hg.mozilla.org/mozilla-central/rev/cc55edd1533d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Did this fix your problems with webaudio in background tabs?
Flags: needinfo?(sole)
I will need to wait until it's in Nightly to test...
Flags: needinfo?(sole)
(In reply to Soledad Penades [:sole] [:spenades] from comment #5)
> I will need to wait until it's in Nightly to test...

This was landed 5 days ago, I think it's in nightly by now.
Flags: needinfo?(sole)
I’ve done doc updates in tandem with bug 1181073 for this (mentioning the difference between Firefox 50 and 51 but writing them up together).
:mystor - I am deeply sorry that I just realised this needinfo was here. I tested this and it's still not quite as I think it should be. The rhythm keeps missing notes, but I was expecting it to keep playing as normal when in the background as the audiocontext is [should be?] active.

I realise you probably have other things in mind right now, but as an audio-on-the-web-interested-person I would love to see if there's a way this can be improved. I promise to be more needinfo-aware next time!

Apologies again! I'm truly sorry.
Flags: needinfo?(sole) → needinfo?(michael)
We recently changed some thing in FF55 beta and FF56 nightly.  Do those behave any differently for you?
Flags: needinfo?(sole)
What did you change? What difference should I see? I tested today using Nightly, that's where I saw the 'not quite right' behaviour that I described in comment 8.
Flags: needinfo?(sole)
Can you describe the test steps you are using?
Flags: needinfo?(sole)
Sure!

- I am going to http://sole.github.io/test_cases/web_audio/settimeout/
- Click play
- Change to another tab so this one goes to the background

I'd expect the sound to keep playing smoothly as it is when in the foreground, but notes are skipped and so the beat is not OK
Flags: needinfo?(sole)
I can reproduce.  I'm going to file a new bug.
Thank you, Ben. Very appreciated considering the Quantum workload!
Sounds like Ben has this under control :). Clearing needinfo.
Flags: needinfo?(michael)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.