1291751 - Implement AS bookmarks / history search activity

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Awesomescreen, defect, P3)

Description

[Andrzej Hunt :ahunt]

From the AS Detail activity we can search through bookmarks or history:
https://mozilla.invisionapp.com/share/VW7ZBXV8Q#/screens/175664522

It's probably best to write this from scratch, possibly reusing the CombinedHistoryRecyclerView to actually display search results. (BrowserSearch does a similar thing but is quite complicated, meaning it's probably hard to extract just the bookmarks/history filtering.)

The only difference between the bookmarks/history searches should be the underlying query, so we can have one implementation with a switch to select what we're searching.

Comment 1

[Andrzej Hunt :ahunt]

Attachment: Bug 1291751 - Implement ASSearchActivity for bookmarks/history search

Review commit: https://reviewboard.mozilla.org/r/68972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68972/

Comment 2

[Andrzej Hunt :ahunt]

Attachment: Bug 1291751 - Enable searching from ASDetailActivity

Review commit: https://reviewboard.mozilla.org/r/68974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68974/

Comment 3

[Andrzej Hunt :ahunt]

Attachment: Bug 1291751 - Allow filter() on just bookmarks or history

filter() previously operated on both bookmarks and history at the same time, i.e. by
using the combined table. For the AS detail-view search functionality we want
to be able to search on just history, or just bookmarks. For now it's probably
best to implement this by filtering out history or bookmarks as appropriate in
the existing search (the specs aren't finalised yet, and this provides a good
interim solution). In future we might want to have optimised specific
queries for history and bookmarks separately, but we'll want to have telemetry
data on how often these views are even used before investing in that.

Review commit: https://reviewboard.mozilla.org/r/69070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69070/

Comment 4

[Andrzej Hunt :ahunt]

Attachment: Bug 1291751 - Use history or bookmarks search mode as appropriate in AS-search

Review commit: https://reviewboard.mozilla.org/r/69072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69072/

Comment 5

[Andrzej Hunt :ahunt]

Comment on attachment 8777402 [details]
Bug 1291751 - Implement ASSearchActivity for bookmarks/history search

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68972/diff/1-2/

Comment 6

[Andrzej Hunt :ahunt]

Comment on attachment 8777403 [details]
Bug 1291751 - Enable searching from ASDetailActivity

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68974/diff/1-2/

Comment 7

[Andrzej Hunt :ahunt]

Comment on attachment 8777523 [details]
Bug 1291751 - Allow filter() on just bookmarks or history

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69070/diff/1-2/

Comment 8

[Andrzej Hunt :ahunt]

Comment on attachment 8777524 [details]
Bug 1291751 - Use history or bookmarks search mode as appropriate in AS-search

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69072/diff/1-2/

Comment 9

[Andrzej Hunt :ahunt]

Unassigning since this isn't something we're doing right now.

Comment 10

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.