Closed Bug 1291769 Opened 3 years ago Closed 3 years ago

expandable/collapsible arrow always depicts collapsed state (e.g. in bookmarks sidebar)

Categories

(Core :: Widget: Gtk, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: stransky, Unassigned)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1350989

arrows are not updated when sub-menu is expanded.
That's moz_gtk_treeview_expander_paint() code which is affected here. Looks like we need to set correct class for GTK_EXPANDER_EXPANDED - implement that for 3.20 code.
Depends on: 1288413
Attached patch patchSplinter Review
Just a simple fix for this one, the same situation as for checkboxes. Thanks.
Attachment #8777560 - Flags: review?(andrew)
Comment on attachment 8777560 [details] [diff] [review]
patch

Review of attachment 8777560 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #8777560 - Flags: review?(andrew) → review+
Note: Needs land Bug 1288413 before this one.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2832042ac206
use correct "checked" state for treeview expanders, r=acomminos
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2832042ac206
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.