1291770 - [HiDPI] Globe icon is too small, ends up being scaled up

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Ryan Feeley [:rfeeley]]

Attachment: globe.png

Currently the globe icon that appears in many places like tab is too big and being scaled down, resulting in a less-than-perfect round shape.

Comment 1

[Ryan Feeley [:rfeeley]]

Attachment: Globe-assets.zip

Attached are the PNG files that should replace the other versions.

Comment 2

[Ryan Feeley [:rfeeley]]

Attachment: globe.png

Still a problem, even in the awesomebar. More noticeable on retina screens.

Comment 3

[Justin Dolske [:Dolske]]

Ha, so, comment 0 is basically right. The weirdness in attachment 8816226 [details] is because the in-tree icons are 30x30 instead of 32x32. They're being upscaled to 32x32, resulting in the unround shape. (I padded the existing icons to double-check.) Bug 1224653 regressed this.

Comment 4

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Verified fix with http://peanutbutterjellytime.vorb.is/ (which doesn't have a favicon, and is awesome), both pinned tab and awesomebar results are ok now.

Ryan's images are very slightly lighter that the current in-tree images, which probably helps a bit with bug 1238907 anyway. Before bug 1224653 the globe color, on a white background, was rgb(215,215,215), currently it's rgb(140,140,140), with this patch it's rgb(160,160,160).

Comment 5

[Justin Dolske [:Dolske]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/237ba7e9c898fe41563b04afb2e4e16f1b96cf9a
Bug 1291770 - [HiDPI] Globe icon is too small, ends up being scaled up. r=dao

Comment 6

[Justin Dolske [:Dolske]]

Comment on attachment 8816313 [details] [diff] [review]
Patch v.1

Approval Request Comment
[Feature/Bug causing the regression]: bug 1224653 
[User impact if declined]: minor visual glitch of icon that appears in primary chrome.
[Is this code covered by automated tests?]: n/a
[Has the fix been verified in Nightly?]: pending
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple image swap.
[String changes made/needed]: n/a

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/237ba7e9c898

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 8816313 [details] [diff] [review]
Patch v.1

fix visual glitch on hidpi, in aurora52

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4f7ec297c3ac

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8816313 [details] [diff] [review]
Patch v.1

Fix a visual glitch for HiDPI. Beta51+. Should be in 51 beta 7.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c29fbfced2b1

Comment 12

[Paul Silaghi, QA [:pauly]]

Verified fixed FX 51b9, 52.0a2 (2016-12-19), 53.0a1 (2016-12-19) OS X 10.11.5.