[HiDPI] Globe icon is too small, ends up being scaled up

VERIFIED FIXED in Firefox 51

Status

()

defect
P3
normal
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: rfeeley, Assigned: Dolske)

Tracking

({regression})

50 Branch
Firefox 53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 verified, firefox52 verified, firefox53 verified)

Details

Attachments

(4 attachments)

Posted image globe.png
Currently the globe icon that appears in many places like tab is too big and being scaled down, resulting in a less-than-perfect round shape.
Posted file Globe-assets.zip
Attached are the PNG files that should replace the other versions.
Component: General → Theme
Priority: -- → P3
Posted image globe.png
Still a problem, even in the awesomebar. More noticeable on retina screens.
Ha, so, comment 0 is basically right. The weirdness in attachment 8816226 [details] is because the in-tree icons are 30x30 instead of 32x32. They're being upscaled to 32x32, resulting in the unround shape. (I padded the existing icons to double-check.) Bug 1224653 regressed this.
Posted patch Patch v.1Splinter Review
Verified fix with http://peanutbutterjellytime.vorb.is/ (which doesn't have a favicon, and is awesome), both pinned tab and awesomebar results are ok now.

Ryan's images are very slightly lighter that the current in-tree images, which probably helps a bit with bug 1238907 anyway. Before bug 1224653 the globe color, on a white background, was rgb(215,215,215), currently it's rgb(140,140,140), with this patch it's rgb(160,160,160).
Assignee: nobody → dolske
Attachment #8816313 - Flags: review?(dao+bmo)
Blocks: 1224653
Keywords: regression
Summary: Replace globe icons with right-sized versions → [HiDPI] Globe icon is too small, ends up being scaled up
Attachment #8816313 - Flags: review?(dao+bmo) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/237ba7e9c898fe41563b04afb2e4e16f1b96cf9a
Bug 1291770 - [HiDPI] Globe icon is too small, ends up being scaled up. r=dao
Comment on attachment 8816313 [details] [diff] [review]
Patch v.1

Approval Request Comment
[Feature/Bug causing the regression]: bug 1224653 
[User impact if declined]: minor visual glitch of icon that appears in primary chrome.
[Is this code covered by automated tests?]: n/a
[Has the fix been verified in Nightly?]: pending
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple image swap.
[String changes made/needed]: n/a
Attachment #8816313 - Flags: approval-mozilla-beta?
Attachment #8816313 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/237ba7e9c898
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Comment on attachment 8816313 [details] [diff] [review]
Patch v.1

fix visual glitch on hidpi, in aurora52
Attachment #8816313 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8816313 [details] [diff] [review]
Patch v.1

Fix a visual glitch for HiDPI. Beta51+. Should be in 51 beta 7.
Attachment #8816313 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified fixed FX 51b9, 52.0a2 (2016-12-19), 53.0a1 (2016-12-19) OS X 10.11.5.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.