Closed Bug 1291770 Opened 4 years ago Closed 4 years ago
DPI] Globe icon is too small, ends up being scaled up
5.39 KB, image/png
6.02 KB, application/zip
8.97 KB, image/png
5.11 KB, patch
|Details | Diff | Splinter Review|
Currently the globe icon that appears in many places like tab is too big and being scaled down, resulting in a less-than-perfect round shape.
Attached are the PNG files that should replace the other versions.
Still a problem, even in the awesomebar. More noticeable on retina screens.
Ha, so, comment 0 is basically right. The weirdness in attachment 8816226 [details] is because the in-tree icons are 30x30 instead of 32x32. They're being upscaled to 32x32, resulting in the unround shape. (I padded the existing icons to double-check.) Bug 1224653 regressed this.
Verified fix with http://peanutbutterjellytime.vorb.is/ (which doesn't have a favicon, and is awesome), both pinned tab and awesomebar results are ok now. Ryan's images are very slightly lighter that the current in-tree images, which probably helps a bit with bug 1238907 anyway. Before bug 1224653 the globe color, on a white background, was rgb(215,215,215), currently it's rgb(140,140,140), with this patch it's rgb(160,160,160).
Assignee: nobody → dolske
Attachment #8816313 - Flags: review?(dao+bmo)
https://hg.mozilla.org/integration/mozilla-inbound/rev/237ba7e9c898fe41563b04afb2e4e16f1b96cf9a Bug 1291770 - [HiDPI] Globe icon is too small, ends up being scaled up. r=dao
Comment on attachment 8816313 [details] [diff] [review] Patch v.1 Approval Request Comment [Feature/Bug causing the regression]: bug 1224653 [User impact if declined]: minor visual glitch of icon that appears in primary chrome. [Is this code covered by automated tests?]: n/a [Has the fix been verified in Nightly?]: pending [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: n/a [Is the change risky?]: no [Why is the change risky/not risky?]: simple image swap. [String changes made/needed]: n/a
Comment on attachment 8816313 [details] [diff] [review] Patch v.1 fix visual glitch on hidpi, in aurora52
Attachment #8816313 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8816313 [details] [diff] [review] Patch v.1 Fix a visual glitch for HiDPI. Beta51+. Should be in 51 beta 7.
Attachment #8816313 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified fixed FX 51b9, 52.0a2 (2016-12-19), 53.0a1 (2016-12-19) OS X 10.11.5.
You need to log in before you can comment on or make changes to this bug.