1291786 - stylo: Deal with mismatch between Gecko's eRestyle_Subtree and servo's RESTYLE_SELF + RESTYLE_DESCENDANTS

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Emilio Cobos Álvarez (:emilio)]

TL;DR:

    RESTYLE_SELF should not (always) run selector matching on descendants (that's eRestyle_Subtree, which currently is lacking on Servo). This is a known (hopefully soon-to-be-addressed issue). We treat both like the same right now.

    RESTYLE_DESCENDANTS and eRestyle_SomeDescendants share binary representations right now, but the meanings for Gecko and Servo are different (all vs. some). In practice this doesn't matter much since it's impossible for a Gecko-generated eRestyle_SomeDescendants to reach the Servo restyle manager, but we should be aware of this and presumably give it a more meaningful name, or pick another spot, or something.

Comment 1

[Bobby Holley (:bholley)]

Bug 1346018 covers the SomeDescendants case, and bug 1338461 covers eRestyle_StyleAttribute.

I think we should deal with the remaining mismatch in RestyleHint::from<nsRestyleHint>. We can make the eRestyle_Subtree bit position correspond to RESTYLE_DESCENDANTS, and add in RESTYLE_SELF when we encounter it.

This is a 5-minute job.

Comment 2

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=68a85f7ebcb286f516799659446195f504afbc31

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Bug 1291786 - stylo: Move eRestyle_Subtree translation handling to Servo.

Review commit: https://reviewboard.mozilla.org/r/119030/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119030/

Comment 4

[Cameron McCormack (:heycam)]

Attachment: Align eRestyle_Subtree value with RESTYLE_DESCENDANTS.

Handle the translation of eRestyle_Subtree into
(RESTYLE_SELF | RESTYLE_DESCENDANTS) in the From impl, too.

Review commit: https://reviewboard.mozilla.org/r/119032/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119032/

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 8845907 [details]
Align eRestyle_Subtree value with RESTYLE_DESCENDANTS.

https://reviewboard.mozilla.org/r/119032/#review121112

Comment 6

[Bobby Holley (:bholley)]

Comment on attachment 8845906 [details]
Bug 1291786 - stylo: Move eRestyle_Subtree translation handling to Servo.

https://reviewboard.mozilla.org/r/119030/#review121114

Comment 7

[Cameron McCormack (:heycam)]

Comment on attachment 8845906 [details]
Bug 1291786 - stylo: Move eRestyle_Subtree translation handling to Servo.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/119030/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d35259473a29
stylo: Move eRestyle_Subtree translation handling to Servo. r=bholley

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d35259473a29