1291856 - GTK 3.4.2 does not clip clearing of window background

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Lee Salzman [:lsalzman]]

Attachment: push clip before drawing GTK3 widgets

The version of GTK 3 we use on try does not properly clip a window widget before it clears the background. This causes it to draw outside the dirty rect and fill those pixels with junk.

Comment 1

[Andrew Comminos [:acomminos]]

Comment on attachment 8777518 [details] [diff] [review]
push clip before drawing GTK3 widgets

Review of attachment 8777518 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/gtk/nsNativeThemeGTK.cpp
@@ +868,5 @@
>  
>    cairo_matrix_t mat;
>    GfxMatrixToCairoMatrix(transform, mat);
>  
> +  IntSize clipSize = IntSize::Ceil(Size(aDrawSize) / aScaleFactor);

This is fine, but it might be nicer to stick to integer division, i.e. 

IntSize((aDrawSize.width + aScaleFactor - 1) / aScaleFactor, (aDrawSize.height + aScaleFactor - 1) / aScaleFactor)

I'm assuming the widget overflow is included by layout in aDirtyRect.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2fb36bd0bcf
push clip before drawing GTK3 widgets. r=acomminos

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d2fb36bd0bcf