Closed Bug 129192 Opened 22 years ago Closed 22 years ago

[FIX]View source uses ReplaceSubstring() in HandleToken()

Categories

(SeaMonkey :: UI Design, defect)

Product:
SeaMonkey
Component:
UI Design
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

Patch v 1.1
2.31 KB, patch
harishd
: review+
jst
: superreview+
asa
: approval+
Details | Diff | Splinter Review 
On that page, 33% of the time is spent in ReplaceSubstring()
Blocks: 84707
QA Contact: sairuh → pmac
Attached patch Patch to fix (obsolete) — — Splinter Review 
It looks like that code is no longer necessary....  I retested bug 40809 with
this patch applied and it looked just fine.
As a note, that patch speeds up viewsource load on the testcase by the entire
30-some percent (goes from 1097 profiler ticks to 687 and from 15sec to 10sec
wall clock time).
boris: 
1) How did you come to the conclusion that the code isn't necessary? bug 40809?
2) Can we also remove mCDATAContainer?
3) Have you tested with <SCRIPT> and <STYLE> tags? 
> 1) How did you come to the conclusion that the code isn't necessary? bug
> 40809?

Exactly.  I took the code out then tested the testcases in bug 40809.  I tested
on Linux, but that should not matter...  The testcase passed.

> 2) Can we also remove mCDATAContainer?

Yes, we can.  Patch that does that coming up.

> 3) Have you tested with <SCRIPT> and <STYLE> tags? 

Yes, and also with <noframes>
Attached patch Patch v 1.1 — — Splinter Review 

        Attachment #72920 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 72992 [details] [diff] [review]
Patch v 1.1

r=harishd

        Attachment #72992 -
        Flags: review+

    
    

    
  
boris: Did you test on Mac? Bug 40809 is Mac. related.

    
    

    
  
I haven't tested on Mac, but I have tested on mac-created files.  Furthermore, I
got a linux version of M16 and reproduced bug 40809 on Linux with that.  So bug
40809 was XP.

    
    

    
  
Comment on attachment 72992 [details] [diff] [review]
Patch v 1.1

sr=jst

        Attachment #72992 -
        Flags: superreview+

    
  
Summary: View source uses ReplaceSubstring() in HandleToken() → [FIX]View source uses ReplaceSubstring() in HandleToken()

    
    

    
  
Comment on attachment 72992 [details] [diff] [review]
Patch v 1.1

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

        Attachment #72992 -
        Flags: approval+

    
    

    
  
checked in on trunk
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Product: Core → Mozilla Application Suite

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: