Closed Bug 1291953 Opened 3 years ago Closed 3 years ago

Intermittent dom/media/test/test_video_dimensions.html | Test timed out.

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: ctai)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Component: Audio/Video → Audio/Video: Playback
fallout from bug 1201363?
Depends on: 1201363
The bug 1201363 is landed in 2016-08-04 07:16:03 PDT.
And this bug is reported before it.
So I don't think bug 1201363 is related to this bug.
But if you have more evidence, feel free to add the dependency. 
see: https://bugzilla.mozilla.org/show_bug.cgi?id=1201363#c178
No longer depends on: 1201363
Assignee: nobody → ctai
Comment on attachment 8781364 [details]
Bug 1291953 - Call mozCapturedStreamXXX in onloadedmetadata callback. .

https://reviewboard.mozilla.org/r/71490/#review69372

I think you can, in v1's "loadedmetadata" call v2.load() and then in v2's "loadedmetadata" call v2.mozCaptureStream() and v2.play().

::: dom/media/test/test_video_dimensions.html:51
(Diff revision 1)
>      if (v === v1) {
>        removeNodeAndSource(v1);
> +      vout.src = URL.createObjectURL(v2.mozCaptureStreamUntilEnded());
> +      setupElement(vout, "vout");
>        v2.play();
>        vout.play();
>      }

This might not work because you're in v1's "loadedmetadata" handler.

::: dom/media/test/test_video_dimensions.html:54
(Diff revision 1)
>  
>      numVideoElementsFinished += 1;
>      if (v === v1) {
>        removeNodeAndSource(v1);
> +      vout.src = URL.createObjectURL(v2.mozCaptureStreamUntilEnded());
> +      setupElement(vout, "vout");

You don't need to move the setupElement() for vout.
Attachment #8781364 - Flags: review?(pehrson)
Comment on attachment 8781364 [details]
Bug 1291953 - Call mozCapturedStreamXXX in onloadedmetadata callback. .

https://reviewboard.mozilla.org/r/71490/#review69372

> This might not work because you're in v1's "loadedmetadata" handler.

It only works in v1's "loadedmetadata" callback.
Comment on attachment 8781364 [details]
Bug 1291953 - Call mozCapturedStreamXXX in onloadedmetadata callback. .

https://reviewboard.mozilla.org/r/71490/#review69372

Good suggestion, I will change it this way. :)
Comment on attachment 8781364 [details]
Bug 1291953 - Call mozCapturedStreamXXX in onloadedmetadata callback. .

https://reviewboard.mozilla.org/r/71490/#review69768
Attachment #8781364 - Flags: review?(pehrson)
Comment on attachment 8781364 [details]
Bug 1291953 - Call mozCapturedStreamXXX in onloadedmetadata callback. .

https://reviewboard.mozilla.org/r/71490/#review69770
Attachment #8781364 - Flags: review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5ee895610f49
Call mozCapturedStreamXXX in onloadedmetadata callback. r=pehrsons.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5ee895610f49
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
(In reply to OrangeFactor Robot from comment #14)
> 14 automation job failures were associated with this bug in the last 7 days.
> 
> Repository breakdown:
> * autoland: 8
> * mozilla-inbound: 4
> * fx-team: 2
> 
> Platform breakdown:
> * linux64: 7
> * windows7-32-vm: 2
> * osx-10-10: 2
> * linux32: 2
> * windows8-64: 1
> 
> For more details, see:
> https://brasstacks.mozilla.com/orangefactor/
> ?display=Bug&bugid=1291953&startday=2016-08-15&endday=2016-08-21&tree=all

My fix is not included in the last failure. Let's monitor it.
You need to log in before you can comment on or make changes to this bug.