Closed Bug 1291972 Opened 3 years ago Closed 3 years ago

Decrease inspector sidebar min-width to 350px

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox50 fixed, firefox51 fixed)

RESOLVED FIXED
Firefox 51
Tracking Status
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: ntim, Assigned: Honza)

Details

Attachments

(1 file, 2 obsolete files)

I find 450px too big, I'd rather have a 350px/400px sidebar.
Inspector bug triage, filter on CLIMBING SHOES.
Severity: normal → enhancement
Priority: -- → P3
Attached patch bug1291972.patch (obsolete) — Splinter Review
I am attaching a patch that reverts the min-size to 250px, which was the previous value [1] (btw. the changes was introduced in [2])

Honza


[1] https://hg.mozilla.org/mozilla-central/diff/f249501590e6/devtools/client/inspector/inspector.css#l11
[2] Bug 1259819
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Attachment #8781891 - Flags: review?(jdescottes)
Comment on attachment 8781891 [details] [diff] [review]
bug1291972.patch

Review of attachment 8781891 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me, thanks!
Up to you, but I would prefer to use 300px for now to minimize the risk of users hiding the Fonts panel without realizing it.

::: devtools/client/inspector/inspector.css
@@ +6,3 @@
>  #inspector-sidebar-container {
>    overflow: hidden;
> +  min-width: 250px;

Just want to suggest 300px :)

With 250px, the Fonts tab can get completely hidden. I think we should still wait for bug 1281789 before restoring this value.

With 300px, the Fonts tab should remain visible on Windows and OSX (it still gets hidden on Linux which has a bigger font-size).
Attachment #8781891 - Flags: review?(jdescottes) → review+
Attached patch bug1291972.patch (obsolete) — Splinter Review
(In reply to Julian Descottes [:jdescottes] from comment #3)
> Comment on attachment 8781891 [details] [diff] [review]
> bug1291972.patch
> 
> Review of attachment 8781891 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Works for me, thanks!
> Up to you, but I would prefer to use 300px for now to minimize the risk of
> users hiding the Fonts panel without realizing it.
> 
> ::: devtools/client/inspector/inspector.css
> @@ +6,3 @@
> >  #inspector-sidebar-container {
> >    overflow: hidden;
> > +  min-width: 250px;
> 
> Just want to suggest 300px :)
OK, works for me, patch updated.

Honza
Attachment #8781891 - Attachment is obsolete: true
Attachment #8781907 - Flags: review+
Attached patch bug1291972.patchSplinter Review
Rebasing.

Honza
Attachment #8781907 - Attachment is obsolete: true
Attachment #8781944 - Flags: review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/27d5ebc65560
Decrease inspector sidebar min-width to 300px. r=jdescottes
Keywords: checkin-needed
Comment on attachment 8781944 [details] [diff] [review]
bug1291972.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1259819
[User impact if declined]: user cannot resize the sidebar to a smaller width than 450px
[Describe test coverage new/current, TreeHerder]: on fx-team, soon nightly
[Risks and why]: low, one line css fix
[String/UUID change made/needed]: no
Attachment #8781944 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/27d5ebc65560
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Comment on attachment 8781944 [details] [diff] [review]
bug1291972.patch

CSS only, low risk, Aurora50+
Attachment #8781944 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.