1291972 - Decrease inspector sidebar min-width to 350px

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Tim Nguyen :ntim]

I find 450px too big, I'd rather have a 350px/400px sidebar.

Comment 1

[Julian Descottes [:jdescottes]]

Inspector bug triage, filter on CLIMBING SHOES.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1291972.patch

I am attaching a patch that reverts the min-size to 250px, which was the previous value [1] (btw. the changes was introduced in [2])

Honza


[1] https://hg.mozilla.org/mozilla-central/diff/f249501590e6/devtools/client/inspector/inspector.css#l11
[2] Bug 1259819

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8781891 [details] [diff] [review]
bug1291972.patch

Review of attachment 8781891 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me, thanks!
Up to you, but I would prefer to use 300px for now to minimize the risk of users hiding the Fonts panel without realizing it.

::: devtools/client/inspector/inspector.css
@@ +6,3 @@
>  #inspector-sidebar-container {
>    overflow: hidden;
> +  min-width: 250px;

Just want to suggest 300px :)

With 250px, the Fonts tab can get completely hidden. I think we should still wait for bug 1281789 before restoring this value.

With 300px, the Fonts tab should remain visible on Windows and OSX (it still gets hidden on Linux which has a bigger font-size).

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1291972.patch

(In reply to Julian Descottes [:jdescottes] from comment #3)
> Comment on attachment 8781891 [details] [diff] [review]
> bug1291972.patch
> 
> Review of attachment 8781891 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Works for me, thanks!
> Up to you, but I would prefer to use 300px for now to minimize the risk of
> users hiding the Fonts panel without realizing it.
> 
> ::: devtools/client/inspector/inspector.css
> @@ +6,3 @@
> >  #inspector-sidebar-container {
> >    overflow: hidden;
> > +  min-width: 250px;
> 
> Just want to suggest 300px :)
OK, works for me, patch updated.

Honza

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1291972.patch

Rebasing.

Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/27d5ebc65560
Decrease inspector sidebar min-width to 300px. r=jdescottes

Comment 7

[Tim Nguyen :ntim]

Comment on attachment 8781944 [details] [diff] [review]
bug1291972.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1259819
[User impact if declined]: user cannot resize the sidebar to a smaller width than 450px
[Describe test coverage new/current, TreeHerder]: on fx-team, soon nightly
[Risks and why]: low, one line css fix
[String/UUID change made/needed]: no

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/27d5ebc65560

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8781944 [details] [diff] [review]
bug1291972.patch

CSS only, low risk, Aurora50+

Comment 10

[Tim Nguyen :ntim]

Landed on Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/36fd886d42c1