1291991 - Attendees context menu is missing two items for sending email to attendees

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Paul Morris [:pmorris]]

In the attendee tab the context menu is not displaying the options to send an email to all attendees or to undecided attendees.  These should be visible if you have added at least one attendee.  These are the missing menuitems: attendee-popup-sendemail-menuitem and attendee-popup-sendtentativeemail-menuitem

Comment 1

[Paul Morris [:pmorris]]

Here is a diff of a proposed fix.  In calendar-event-dialog.js, in the attendeeClick function around line 3676, https://dxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog.js#3676


     } else {
         if (window.attendees.length > 1) {
             let removeall = document.getElementById("attendee-popup-removeallattendees-menuitem");
             showElement(removeall);
         }
+        let sendEmail = document.getElementById("attendee-popup-sendemail-menuitem");
+        let sendTentativeEmail = document.getElementById("attendee-popup-sendtentativeemail-menuitem");
+        let firstSeparator = document.getElementById("attendee-popup-first-separator");
+        [sendEmail, sendTentativeEmail, firstSeparator].forEach(showElement);
+
         // setup attendee specific menu items if appropriate otherwise hide respective  menu items
         let mailto = document.getElementById("attendee-popup-emailattendee-menuitem");
         let remove = document.getElementById("attendee-popup-removeattendee-menuitem");
-        let separator = document.getElementById("attendee-popup-second-separator");
+        let secondSeparator = document.getElementById("attendee-popup-second-separator");
         let attId = aEvent.target.parentNode.getAttribute("attendeeid");
         let attendee = window.attendees.find(aAtt => aAtt.id == attId);
         if (attendee) {
-            [mailto, remove, separator].forEach(showElement);
+            [mailto, remove, secondSeparator].forEach(showElement);
             mailto.setAttribute("label", attendee.toString());
             mailto.attendee = attendee;
             remove.attendee = attendee;
         } else {
-            [mailto, remove, separator].forEach(hideElement);
+            [mailto, remove, secondSeparator].forEach(hideElement);
         }

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Can you attach that as a patch for review?

Comment 3

[Paul Morris [:pmorris]]

Attachment: fix-attendees-context-menu.patch

Here's a patch.

Comment 4

[[:MakeMyDay]]

Comment on attachment 8777820 [details] [diff] [review]
fix-attendees-context-menu.patch

Review of attachment 8777820 [details] [diff] [review]:
-----------------------------------------------------------------

r+ - I'll land this for you.

Philipp, this should also go up to ESR as this is a regression.

Comment 5

[[:MakeMyDay]]

https://hg.mozilla.org/comm-central/rev/2633c88ebb4482dcc06c7c7964b00679759ac5e8

The target milestone still needs to be updated once it's configured.

Comment 6

[[:MakeMyDay]]

https://hg.mozilla.org/releases/comm-aurora/rev/c8098a508a25b9e2ab20d674d4184f80ed0a45b0
https://hg.mozilla.org/releases/comm-beta/rev/f392635ba8883345195b4584724dab01c5e08d53
https://hg.mozilla.org/releases/comm-esr45/rev/982be26773fda62d8a45a2eecd8d75700570cb37