Closed Bug 1291991 Opened 3 years ago Closed 3 years ago

Attendees context menu is missing two items for sending email to attendees

Categories

(Calendar :: Dialogs, defect)

Lightning 4.7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pmorris, Assigned: pmorris)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

In the attendee tab the context menu is not displaying the options to send an email to all attendees or to undecided attendees.  These should be visible if you have added at least one attendee.  These are the missing menuitems: attendee-popup-sendemail-menuitem and attendee-popup-sendtentativeemail-menuitem
Summary: Attendees context menu is missing two items for sending emails to attendees → Attendees context menu is missing two items for sending email to attendees
Here is a diff of a proposed fix.  In calendar-event-dialog.js, in the attendeeClick function around line 3676, https://dxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog.js#3676


     } else {
         if (window.attendees.length > 1) {
             let removeall = document.getElementById("attendee-popup-removeallattendees-menuitem");
             showElement(removeall);
         }
+        let sendEmail = document.getElementById("attendee-popup-sendemail-menuitem");
+        let sendTentativeEmail = document.getElementById("attendee-popup-sendtentativeemail-menuitem");
+        let firstSeparator = document.getElementById("attendee-popup-first-separator");
+        [sendEmail, sendTentativeEmail, firstSeparator].forEach(showElement);
+
         // setup attendee specific menu items if appropriate otherwise hide respective  menu items
         let mailto = document.getElementById("attendee-popup-emailattendee-menuitem");
         let remove = document.getElementById("attendee-popup-removeattendee-menuitem");
-        let separator = document.getElementById("attendee-popup-second-separator");
+        let secondSeparator = document.getElementById("attendee-popup-second-separator");
         let attId = aEvent.target.parentNode.getAttribute("attendeeid");
         let attendee = window.attendees.find(aAtt => aAtt.id == attId);
         if (attendee) {
-            [mailto, remove, separator].forEach(showElement);
+            [mailto, remove, secondSeparator].forEach(showElement);
             mailto.setAttribute("label", attendee.toString());
             mailto.attendee = attendee;
             remove.attendee = attendee;
         } else {
-            [mailto, remove, separator].forEach(hideElement);
+            [mailto, remove, secondSeparator].forEach(hideElement);
         }
Can you attach that as a patch for review?
Flags: needinfo?(paul)
Here's a patch.
Flags: needinfo?(paul)
Attachment #8777820 - Flags: review?(philipp)
Attachment #8777820 - Flags: review?(makemyday)
Comment on attachment 8777820 [details] [diff] [review]
fix-attendees-context-menu.patch

Review of attachment 8777820 [details] [diff] [review]:
-----------------------------------------------------------------

r+ - I'll land this for you.

Philipp, this should also go up to ESR as this is a regression.
Attachment #8777820 - Flags: review?(philipp)
Attachment #8777820 - Flags: review?(makemyday)
Attachment #8777820 - Flags: review+
Attachment #8777820 - Flags: approval-calendar-esr?(philipp)
Attachment #8777820 - Flags: approval-calendar-beta?(philipp)
Attachment #8777820 - Flags: approval-calendar-aurora?(philipp)
https://hg.mozilla.org/comm-central/rev/2633c88ebb4482dcc06c7c7964b00679759ac5e8

The target milestone still needs to be updated once it's configured.
Assignee: nobody → paul
Status: NEW → RESOLVED
Closed: 3 years ago
Keywords: regression
Resolution: --- → FIXED
Whiteboard: [update target milestone: 5.3]
Whiteboard: [update target milestone: 5.3]
Target Milestone: --- → 5.3
Version: unspecified → Lightning 4.7
Attachment #8777820 - Flags: approval-calendar-esr?(philipp)
Attachment #8777820 - Flags: approval-calendar-esr+
Attachment #8777820 - Flags: approval-calendar-beta?(philipp)
Attachment #8777820 - Flags: approval-calendar-beta+
Attachment #8777820 - Flags: approval-calendar-aurora?(philipp)
Attachment #8777820 - Flags: approval-calendar-aurora+
You need to log in before you can comment on or make changes to this bug.