Closed
Bug 1292032
Opened 8 years ago
Closed 8 years ago
Clean up VideoData static constructor methods
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(1 file)
|
52.33 KB,
patch
|
jya
:
review+
|
Details | Diff | Splinter Review |
It's really hard to tell which of these overloads are being called (one is never called at all!), and the name sort of hides that this makes a copy of the data. This patches renames them to something more obvious, and removes a bunch of unused functions and code branches.
Attachment #8777669 -
Flags: review?(jyavenard)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8777669 [details] [diff] [review] Clean up VideoData constructors Review of attachment 8777669 [details] [diff] [review]: ----------------------------------------------------------------- Awesome.. Everytime I would be near that could I would have been thinking WTF is this function doing... glad you did it.
Attachment #8777669 -
Flags: review?(jyavenard) → review+
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/906df3f2cce7 Clean up VideoData static constructor methods. r=jya
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/906df3f2cce7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
||
Comment 4•7 years ago
|
||
Should we uplift this patch to firefox 50 at this point since it has a good chance to fix the crashes in Bug 1292032 ?
Flags: needinfo?(matt.woodrow)
|
|
||
Comment 5•7 years ago
|
||
According to Bug 1292273 comment 94, cancel the needinfo.
Flags: needinfo?(matt.woodrow)
You need to log in
before you can comment on or make changes to this bug.
Description
•