Closed Bug 1292059 Opened 3 years ago Closed 3 years ago

Remove now useless compiler checks in compiler-opts.m4

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Since bug 1259382, CC and CXX are always set, so we can stop
falling back to cl on Windows, and clang on OSX in compiler-opts.m4.

Also, we were actively rejecting GCC on OSX because it was based on
GCC 4.2 and known to be broken, but that test predates our requirement
for more recent versions of GCC, which would fail configure anyways.
So just remove that GCC test. Building with a modern GCC from macports
or wherever might actually work anyways.

Review commit: https://reviewboard.mozilla.org/r/69220/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69220/
Attachment #8777706 - Flags: review?(cmanchester)
Comment on attachment 8777706 [details]
Bug 1292059 - Remove now useless compiler checks in compiler-opts.m4.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69220/diff/1-2/
Comment on attachment 8777706 [details]
Bug 1292059 - Remove now useless compiler checks in compiler-opts.m4.

https://reviewboard.mozilla.org/r/69220/#review66444
Attachment #8777706 - Flags: review?(cmanchester) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/c2537aae7f7d
Remove now useless compiler checks in compiler-opts.m4. r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/c2537aae7f7d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.