129212 - Memory leak of 9 bytes from 1 block allocated in nsMsgIMAPFolderACL::nsMsgIMAPFolderACL

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID: Latest win32 tip (pulled after David's monster checkin to our URI 
code), under Purify.

Steps to Reproduce:

1.  Just launch an IMAP account (with no new messages).
2.  Shutdown.

[W] MLK: Memory leak of 9 bytes from 1 block allocated in PL_strdup
    Distribution of leaked blocks
         9 bytes from 1 block of 9 bytes (0x09311048) 
    Allocation location
    malloc         [MSVCRT.DLL]
    PL_strdup      [strdup.c:46]
    nsMsgIMAPFolderACL::SetFolderRightsForUser(char const*,char const*) 
[nsImapMailFolder.obj:4992]
    nsMsgIMAPFolderACL::BuildInitialACLFromCache(void) 
[nsImapMailFolder.obj:4931]
    nsMsgIMAPFolderACL::nsMsgIMAPFolderACL(nsImapMailFolder *) 
[nsImapMailFolder.cpp:4896]
      m_folder = folder;
      m_rightsHash = new nsHashtable(24);
      m_aclCount = 0;
 =>   BuildInitialACLFromCache();
    }
    
    nsMsgIMAPFolderACL::~nsMsgIMAPFolderACL()
    nsImapMailFolder::ClearFolderRights(nsIImapProtocol *,nsIMAPACLRightsInfo 
*) [nsImapMailFolder.cpp:4468]
    {
      SetFolderNeedsACLListed(PR_FALSE);
      delete m_folderACL;
 =>   m_folderACL = new nsMsgIMAPFolderACL(this);
      return NS_OK;
    }
    
    ClearFolderRightsProxyEvent::HandleEvent(void) [nsImapProxyEvent.cpp:602]
    
    NS_IMETHODIMP
    ClearFolderRightsProxyEvent::HandleEvent()
     => {
            nsresult res = m_proxy->m_realImapExtensionSink->ClearFolderRights(
                m_proxy->m_protocol, &m_aclRightsInfo);
            if (m_notifyCompletion)
    nsImapEvent::imap_event_handler(PLEvent *) [nsImapProxyEvent.cpp:90]
        nsImapEvent::imap_event_handler(PLEvent *aEvent)
        {
                nsImapEvent* ev = (nsImapEvent*) aEvent;
     =>         ev->HandleEvent();
        }
        
        void PR_CALLBACK
    PL_HandleEvent [plevent.c:590]
    PL_ProcessPendingEvents [plevent.c:520]
    md_EventReceiverProc [plevent.c:1071]
    DestroyWindow  [USER32.dll]
    TranslateMessageEx [USER32.dll]
    DispatchMessageA [USER32.dll]
    DispatchMessageA [USER32.DLL]
    nsAppShell::Run(void) [nsAppShell.cpp:114]
    nsAppShellService::Run(void) [nsAppShellService.cpp:307]
    main1          [nsAppRunner.cpp:1288]
    main           [nsAppRunner.cpp:1636]
    WinMain        [nsAppRunner.cpp:1654]

Comment 1

[David :Bienvenu]

taking

Comment 2

[Mikael Parknert]

Looking at the code from time of bug report shows that a failed PL_strdup
might trigger a leak. Since then code has been changed, but if
'ourUserName' is empty we would get a leak.. Attaching a fix.

Comment 3

[Mikael Parknert]

Attachment: fix

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 170121 [details] [diff] [review]
fix

r=dmose

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fix checked in for 1.8b