1292344 - Move contentWindow-specific logic out of ExtensionContext

Status: RESOLVED DUPLICATE of bug 1292369

(WebExtensions :: Untriaged, defect, P3)

Description

[Rob Wu [:robwu]]

There are different ExtensionContext types:
- ExtensionContext in content script, contentWindow = page's
- ExtensionContext in extension frames in web pages, contentWindow = extension frame's (same limited API as content scripts)
- ExtensionContext in extension frames/pages, contentWindow = extension frame's (full extension API)
- ExtensionContext in browser process serving as a proxy for remote ExtensionContexts, contentwindow = none
- Contexts in tests (sharing the BaseContext with ExtensionContexts), contentWindow = none

The first two are implemented in ExtensionContent.jsm,
the third is implemented in Extension.jsm,
and the contentWindow logic is scattered.

ExtensionContent.jsm has some logic to handle the bfcache, Extension.jsm does not.
In bug 1288901 I saw that the implementation in Extension.jsm changed to something very similar to ExtensionContent.jsm. So I expect more bugs and duplicate efforts unless the contentWindow management logic moves to a single place (ExtensionUtils?).

Comment 1

[Rob Wu [:robwu]]

Fixed by bug 1292369, the content window setter logic is now in BaseContext.