1292355 - firefox-ui-tests should use MINIDUMP_SAVE_PATH to upload minidump files as artifacts

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Right now we do not set this environment variable and as result our jobs (or better taskcluster) do not upload any minidump files to S3, which then would be displayed as artifacts for manual analysis.

Given that we see lots of crashes lately, we should get this added ASAP.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1292355 - firefox-ui-tests should upload minidump files as artifacts.

Review commit: https://reviewboard.mozilla.org/r/71216/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71216/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8780502 [details]
Bug 1292355 - firefox-ui-tests should upload minidump files as artifacts.

https://reviewboard.mozilla.org/r/71216/#review69104

Not that easy to produce a crash those days. But checking the log output the environment variable gets set correctly.

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8780502 [details]
Bug 1292355 - firefox-ui-tests should upload minidump files as artifacts.

https://reviewboard.mozilla.org/r/71216/#review69442

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a487cda5bac
firefox-ui-tests should upload minidump files as artifacts. r=maja_zf

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8a487cda5bac

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It would be great to get this simply mozharness patch backported to aurora and beta to allow a better crash analysis close to our release builds.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This hit a conflict on beta that didn't seem simple enough for me to make judgement calls on.

https://hg.mozilla.org/releases/mozilla-aurora/rev/3443b3c75323

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

In that case I think it's fine to have on mozilla-aurora. There is no real need to backport to mozilla-beta given that we were living fine with that situation for a long time.