1292407 - OBJ_DIR must be inside Gecko checkout or git would cry

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The example code here [1] works:

ac_add_options --enable-artifact-builds
mk_add_options MOZ_OBJDIR=./objdir-artifact

However it fails as soon as I do

ac_add_options --enable-artifact-builds
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../obj-@CONFIG_GUESS@

Instead. It stops at [2]

[1] http://www.ncalexander.net/blog/2015/12/31/firefox-artifact-builds-for-mac/


[2] 

 0:15.51 fatal: Not a git repository (or any of the parent directories): .git
 0:15.52 Error running mach:
 0:15.52
 0:15.52     ['--log-no-times', 'artifact', 'install']
 0:15.52
 0:15.52 The error occurred in code that was called by the mach command. This is either
 0:15.52 a bug in the called code itself or in the way that mach is calling it.
 0:15.52
 0:15.52 You should consider filing a bug for this issue.
 0:15.52
 0:15.52 If filing a bug, please include the full output of mach, including this error
 0:15.52 message.
 0:15.52
 0:15.52 The details of the failure are as follows:
 0:15.52
 0:15.52 CalledProcessError: Command '[u'/usr/local/bin/git', u'rev-list', u'--topo-order', u'--max-count=500', u'HEAD']' returned non-zero exit status 128
 0:15.52
 0:15.52   File "/Users/timdream/Repositories/gecko/gecko-dev/python/mozbuild/mozbuild/mach_commands.py", line 1513, in artifact_install
 0:15.52     return artifacts.install_from(source, self.distdir)

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I can see there is a self._topsrcdir being used in one place as the argument named 'cmd' in a subprocess.check_output() call. I wonder if that's the solutions -- simply make sure all calls are called with cwd=self._topsrcdir.

I can come up with a quick patch if this is the right direction.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

s/cmd/cwd/, obviously.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1292407 - Make artifact install call git with cwd equal to topsrcdir,

Review commit: https://reviewboard.mozilla.org/r/69494/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69494/

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8778114 [details]
Bug 1292407 - Make artifact install call git with cwd equal to topsrcdir,

https://reviewboard.mozilla.org/r/69494/#review66782

<p>I think this makes sense -- thanks, Tim!  Could you make the commit description something that references artifacts and the source directory?  Say,</p>
<p>"Make artifact install call git with cwd equal to topsrcdir"</p>

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8778114 [details]
Bug 1292407 - Make artifact install call git with cwd equal to topsrcdir,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69494/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c16ff57f00ee
Make artifact install call git with cwd equal to topsrcdir, r=nalexander

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c16ff57f00ee