129243 - javascript error in editorApplicationOverlay.js when selecting Edit Page when viewing plugin

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[Henrik Gemal]

if you have the PDF plugin installed and go to:
http://home.earthlink.net/~salhir/ExtendingTheUML-UMLWorld2001.PDF
and select File -> Edit Page this will show up in the console:

Error: launchWindow._content.document has no properties
Source File: chrome://editor/content/editorApplicationOverlay.js
Line: 118

20020305

Comment 1

[kinmoz]

--> Editor:Composer

Comment 2

[Charles Manske]

Obviously we can't edit a PDF page, we simply need to check for 
"launchWindow._content.document" before continuing on, which will result in 
an alert dialog that we can't edit that page.
Trivial fix.

Comment 3

[Charles Manske]

Attachment: Fix

Comment 4

[Kathleen :Brade]

While you are in there, why don't you remove:
 if ( !windowManagerInterface ) return;

and add a check for "popup" before line 55 to fix the JS warning at startup?

of course, I'd also like to see a try/catch in "editPage" ;-)

Comment 5

[Kathleen :Brade]

by the way, if you fix the "popup" startup warning, that is part of bug 108745
so we could reference that bug as well (if necessary).

Comment 6

[Charles Manske]

Attachment: Update

Added brade's suggestions: Put most all of the method inside try {} block
and fixed popup issue.

Comment 7

[Charles Manske]

Attachment: Update (wrong file before)

Comment 8

[Kathleen :Brade]

Comment on attachment 73030 [details] [diff] [review]
Update (wrong file before)

r=brade

Comment 9

[Charles Manske]

Attachment: Identical patch with -w for better review readability

Comment 10

[kinmoz]

Comment on attachment 73030 [details] [diff] [review]
Update (wrong file before)

sr=[e-mail]

Comment 11

[Charles Manske]

Note that this can't be checked in before bug 112181. It depends on the 
replacement of nsEditorShellMouseListener with new nsHTMLEditorMouseListener.

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 73685 [details] [diff] [review]
Identical patch with -w for better review readability

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 13

[Charles Manske]

Forget comment #11. Wrong bug!
checked in.

Comment 14

[sujay]

henrik, please verify...thanks!

Comment 15

[Charles Manske]

Just follow the original directions. You should get the "can't edit page in 
Composer" dialog message and then Composer window should close.

Comment 16

[Henrik Gemal]

v 20020320
getting "cant edit page"

not really sure why we handle plugins differently than images. The File -> Edit
Page option is just disabled for images. Wouldn't that be a much better solution?
Try going to http://gemal.dk/pics/gemaldk.gif and check the File menu.