Closed Bug 1292449 Opened 5 years ago Closed 5 years ago

Remove some more IsShutdown() checks from MediaDecoder

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(3 files)

The sequel of bug 1290780.
Assignee: nobody → jwwang
Blocks: 1289288
Depends on: 1290780
Priority: -- → P3
1. Called from SourceBuffer::AppendDataCompletedWithSuccess() where mMediaSource->GetDecoder() is not null so this must happen before Shutdown().
2. Called from SourceBuffer::Ended() where mMediaSource->GetDecoder() is not null.
3. Called from MediaDecoder::ResourceCallback::TimerCallback() which is canceled in Disconnect().

Review commit: https://reviewboard.mozilla.org/r/69502/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69502/
1. Called from SourceBuffer::AppendDataCompletedWithSuccess() where mMediaSource->GetDecoder() is not null.
2. Called from MediaDecoder::ResourceCallback::NotifyBytesDownloaded() which is disconnected in Shutdown().

Review commit: https://reviewboard.mozilla.org/r/69504/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69504/
Attachment #8778117 - Flags: review?(jyavenard)
Attachment #8778118 - Flags: review?(jyavenard)
Attachment #8778119 - Flags: review?(kaku)
Comment on attachment 8778119 [details]
Bug 1292449. Part 3 - Assert IsShutdown() is false in MediaDecoder::Shutdown(). Shutdown() should be only called once.

https://reviewboard.mozilla.org/r/69506/#review66998
Attachment #8778119 - Flags: review?(kaku) → review+
Comment on attachment 8778117 [details]
Bug 1292449. Part 1 - Assert IsShutdown() is false in NotifyDataArrived().

https://reviewboard.mozilla.org/r/69502/#review67004
Attachment #8778117 - Flags: review?(jyavenard) → review+
Comment on attachment 8778118 [details]
Bug 1292449. Part 2 - Assert IsShutdown() is false in NotifyBytesDownloaded().

https://reviewboard.mozilla.org/r/69504/#review67006
Attachment #8778118 - Flags: review?(jyavenard) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c39c23a88c7a
Part 1 - Assert IsShutdown() is false in NotifyDataArrived(). r=jya
https://hg.mozilla.org/integration/autoland/rev/a62419846b2f
Part 2 - Assert IsShutdown() is false in NotifyBytesDownloaded(). r=jya
https://hg.mozilla.org/integration/autoland/rev/e47457d354ec
Part 3 - Assert IsShutdown() is false in MediaDecoder::Shutdown(). Shutdown() should be only called once. r=kaku
You need to log in before you can comment on or make changes to this bug.