Closed
Bug 1292464
Opened 8 years ago
Closed 8 years ago
dom/media/MediaData.cpp:353:34: error: 'aImage' was not declared in this scope
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(firefox51 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
Attachments
(1 file, 3 obsolete files)
|
2.32 KB,
patch
|
gerard-majax
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Updated•8 years ago
|
Summary: /home/worker/workspace/gecko/dom/media/MediaData.cpp:353:34: error: 'aImage' was not declared in this scope → dom/media/MediaData.cpp:353:34: error: 'aImage' was not declared in this scope
|
|
Assignee | |
Comment 1•8 years ago
|
||
MozReview-Commit-ID: 73Hqb7kmTLo
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=18452879a12e
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8778134 -
Flags: review?(matt.woodrow)
|
||
Updated•8 years ago
|
Attachment #8778134 -
Flags: review?(matt.woodrow) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Attachment #8778180 -
Flags: review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
Attachment #8778197 -
Flags: review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
Updated call site of MediaOmxReader to fix:
> 10:12:17 INFO - ../../../../../workspace/gecko/dom/media/omx/MediaOmxReader.cpp: In member function 'virtual bool mozilla::MediaOmxReader::DecodeVideoFrame(bool&, int64_t)':
> 10:12:17 ERROR - ../../../../../workspace/gecko/dom/media/omx/MediaOmxReader.cpp:430:47: error: no matching function for call to 'mozilla::VideoData::CreateAndCopyData(mozilla::VideoInfo&, mozilla::layers::ImageContainer*, int64_t&, int64_t&, int, RefPtr<mozilla::layers::TextureClient>&, bool&, int, mozilla::gfx::IntRect&)'
> 10:12:17 INFO - picture);
> 10:12:17 INFO - ^
> 10:12:17 INFO - ../../../../../workspace/gecko/dom/media/omx/MediaOmxReader.cpp:430:47: note: candidate is:
> 10:12:17 INFO - In file included from ../../../dist/include/MediaInfo.h:16:0,
> 10:12:17 INFO - from ../../../dist/include/AbstractMediaDecoder.h:15,
> 10:12:17 INFO - from ../../../dist/include/MediaDecoderReader.h:13,
> 10:12:17 INFO - from ../../../../../workspace/gecko/dom/media/omx/MediaOmxCommonReader.h:10,
> 10:12:17 INFO - from ../../../../../workspace/gecko/dom/media/omx/MediaOmxReader.h:9,
> 10:12:17 INFO - from ../../../../../workspace/gecko/dom/media/omx/MediaOmxReader.cpp:7:
> 10:12:17 INFO - ../../../dist/include/MediaData.h:466:38: note: static already_AddRefed<mozilla::VideoData> mozilla::VideoData::CreateAndCopyData(const mozilla::VideoInfo&, mozilla::VideoData::ImageContainer*, int64_t, int64_t, int64_t, const mozilla::VideoData::YCbCrBuffer&, bool, int64_t, const IntRect&)
> 10:12:17 INFO - static already_AddRefed<VideoData> CreateAndCopyData(const VideoInfo& aInfo,
> 10:12:17 INFO - ^
> 10:12:17 INFO - ../../../dist/include/MediaData.h:466:38: note: no known conversion for argument 6 from 'RefPtr<mozilla::layers::TextureClient>' to 'const mozilla::VideoData::YCbCrBuffer&'|
|
Assignee | |
Updated•8 years ago
|
Attachment #8778134 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8778180 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e4ac32ec55d
|
|
Assignee | |
Comment 7•8 years ago
|
||
Attachment #8778197 -
Attachment is obsolete: true
Attachment #8778223 -
Flags: review+
|
|
Assignee | |
Comment 8•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f4ffc9284a7
Pushed by alissy@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/167889cfbab1 Followup fix Gonk for VideoData cleanup from bug 1292032 r=mattwoodrow
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/167889cfbab1
You need to log in
before you can comment on or make changes to this bug.
Description
•