1292475 - Nightly cannot receive gamepad event under windows platform

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Michael Leu[:Lenzak](UTC+8)]

Test Environment:
Windows 10 and Nightly with stock PS4 controller via USB

Symptom:
When we go to http://html5gamepad.com with gamepad connected, the page does not receive any events.


Patch is ongoing.

Comment 1

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Fix windows gamepad api backend

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8778138 [details] [diff] [review]
Fix windows gamepad api backend

Review of attachment 8778138 [details] [diff] [review]:
-----------------------------------------------------------------

Oh my. I wish we had automated tests that covered the platform backend implementations. :-(

Comment 3

[Michael Leu[:Lenzak](UTC+8)]

I wish we had this kind of test, too. :(

Comment 4

[Carsten Book [:Tomcat]]

does not apply cleanly :

patching file dom/gamepad/windows/WindowsGamepad.cpp
Hunk #1 FAILED at 752
1 out of 1 hunks FAILED -- saving rejects to file dom/gamepad/windows/WindowsGamepad.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-fix-windows-gamepad-api.patch

Comment 5

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Fix Windows Gamepad API backend to receive event correctly r=ted

I think the reason why the previous patch doesn't apply is because there is a redundant "-" which causes conflict.

This patch should work.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9243f28dbe9
Fix Windows Gamepad API backend to receive event correctly; r=ted

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8778563 [details] [diff] [review]
Fix Windows Gamepad API backend to receive event correctly r=ted

Approval Request Comment
[Feature/regressing bug #]: Bug 1221730 
[User impact if declined]: Any joystick not recognized by xinput won't work on windows
[Describe test coverage new/current, TreeHerder]: Hand tested on windows machines.
[Risks and why]: None
[String/UUID change made/needed]: None

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f9243f28dbe9

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8778563 [details] [diff] [review]
Fix Windows Gamepad API backend to receive event correctly r=ted

Manually tested by dev, has stabilized on Nightly for a few days, Aurora50+

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Kyle, this seems like a regression to me. Is there a way to get some automated tests that can catch regressions like this in the future? Thanks!

Comment 11

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Yeah, we've started talking about platform specific tests for hardware APIs so things like this happen less. It's going to be a long road though.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fd3bb47e076f

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #11)
> Yeah, we've started talking about platform specific tests for hardware APIs
> so things like this happen less. It's going to be a long road though.

Thanks! I am glad we are heading down that path.