"Dumb" download link headings should include channel description.

RESOLVED FIXED

Status

www.mozilla.org
Pages & Content
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: agibson, Assigned: agibson)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
STR:

1.) In Firefox, go to 'about:config' and set 'javascript.enabled' to 'false'.
2.) Visit a page with multiple download buttons, such as https://www.mozilla.org/en-US/firefox/installer-help/.

Expected results:

It should be clear which channel each group of download links relates to.

Actual results:

Each download button is labelled "Download Firefox — English (US)", which gives no indication as to which is Release, Beta, Dev Edition etc.

This bug seems like a minor one, but will become more important if we start to limit serving JS to old IE browsers (bug 1287200). We could likely just reuse the strings already in the download button helper to solve this.
(Assignee)

Updated

2 years ago
Blocks: 1287200
(Assignee)

Updated

2 years ago
Assignee: nobody → agibson
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
Created attachment 8778239 [details] [review]
GitHub pull request
(Assignee)

Comment 2

2 years ago
Created attachment 8778241 [details]
download-headings.png

Screenshot of before/after.

Comment 3

2 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/eb19dac89d152ee451e69d3de603a1fc4efa1df0
[fix bug 1292528] 'Dumb' download link headings should include channel description.

https://github.com/mozilla/bedrock/commit/7a7c7a1ec58cdbcd9560a663028dd6a6cdef168f
Merge pull request #4268 from alexgibson/bug-1292528-dumb-download-link-channel-description

[fix bug 1292528] 'Dumb' download link headings should include channe…

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.