Closed Bug 1292545 Opened 6 years ago Closed 6 years ago

Don't skip the canvas copy-on-write if clips are pushed.

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox48 --- unaffected
firefox49 --- unaffected
firefox-esr45 --- unaffected
firefox50 --- affected
firefox51 --- fixed

People

(Reporter: nical, Assigned: nical)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Take clips into account
2.13 KB, patch
ethlin
: review+
Details | Diff | Splinter Review 
PersistentBufferProviderShared has an optimization to skip copying the previous frame if the next frame start with a command that covers all pixels. This optimization should take clips into accounts (right now it only takes the transform and bounds of the command).
Whiteboard: [gfx-noted]
As a bonus, we can skip clearing the canvas towards the end of EnsureTarget if the next drawing command covers the canvas.
Attachment #8778247 - Flags: review?(ethlin)
Comment on attachment 8778247 [details] [diff] [review]
Take clips into account

Review of attachment 8778247 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8778247 - Flags: review?(ethlin) → review+
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/abcf4616a67f
Don't optimize away the canvas copy if clips are applied. r=ethlin
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4927c9be9167
Don't skip clearing the canvas because of W(1) failures on Mac.
You need to log in before you can comment on or make changes to this bug.