1292573 - Broken keyboard interaction with the subview in the Downloads Panel

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P2)

Description

[:Paolo Amadini]

While testing the styling changes in bug 1001324, I noticed that keyboard interaction with the subview is broken. The space bar doesn't open the subview like the Control Center does, there doesn't seem to be a way to go back to the main view with the keyboard, and for some reason while the subview is visible you can tab through all the invisible action buttons at the right of the selected item.

However, we may be removing keyboard interaction going forward so not all of the above issues may be important to track.

Comment 1

[:Paolo Amadini]

[Tracking Requested - why for this release]:
Quality issue with a new feature developed for Firefox 50 in bug 1252509.

Comment 2

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for Fx50 since this is a regression in a new feature.

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Drew, is there a fix in the works for this issue? I'd happy to uplift to Aurora when ready. I hope we can get a fix ready before 50 goes to Beta.

Comment 4

[Drew Willcoxon :adw]

I haven't started on this one yet since I'm working on other ones, but I'll try to get to it soon.

Comment 5

[Drew Willcoxon :adw]

Attachment: Bug 1292573 - Broken keyboard interaction with the subview in the Downloads Panel.

Review commit: https://reviewboard.mozilla.org/r/74418/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74418/

Comment 6

[Drew Willcoxon :adw]

Control center uses -moz-user-focus: https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/controlcenter/panel.inc.css#64

Comment 7

[:Paolo Amadini]

Comment on attachment 8785101 [details]
Bug 1292573 - Broken keyboard interaction with the subview in the Downloads Panel.

https://reviewboard.mozilla.org/r/74418/#review72372

I've tested on Mac OS X with full keyboard access and I cannot tab to the "open" button in the subview.

::: browser/components/downloads/content/downloads.css:236
(Diff revision 1)
>    -moz-margin-start: 38px !important;
>  }
> +
> +/* Prevent keyboard interaction in the main view by preventing all elements in
> +   the main view from being focused... */
> +#downloadsPanel-multiView > .panel-viewcontainer > .panel-viewstack[viewtype="subview"] > .panel-mainview * {

Having a rightmost "*" selector is probably still to be avoided for performance, we should be more specific like the Control Center does.

Comment 8

[Drew Willcoxon :adw]

I'm on OS X too and I can tab to the open button.  Wonder what the difference is.

Comment 9

[Drew Willcoxon :adw]

Comment on attachment 8785101 [details]
Bug 1292573 - Broken keyboard interaction with the subview in the Downloads Panel.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/74418/diff/1-2/

Comment 10

[Drew Willcoxon :adw]

(with full keyboard access)

Comment 11

[:Paolo Amadini]

Comment on attachment 8785101 [details]
Bug 1292573 - Broken keyboard interaction with the subview in the Downloads Panel.

https://reviewboard.mozilla.org/r/74418/#review72448

Now focusing the "open" button works for me too. Weird.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b15b5785e927
Broken keyboard interaction with the subview in the Downloads Panel. r=Paolo

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b15b5785e927

Comment 14

[Drew Willcoxon :adw]

Comment on attachment 8785101 [details]
Bug 1292573 - Broken keyboard interaction with the subview in the Downloads Panel.

Approval Request Comment
[Feature/regressing bug #]: Sliding subview for blocked download info in the downloads panel, bug 1252509
[User impact if declined]: The subview can't be easily accessed via the keyboard
[Describe test coverage new/current, TreeHerder]: Manual testing
[Risks and why]: Low risk, only impacts key handling in the subview
[String/UUID change made/needed]: None

Comment 15

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Paolo, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8785101 [details]
Bug 1292573 - Broken keyboard interaction with the subview in the Downloads Panel.

Fixes a regression, Aurora50+

Comment 17

[:Paolo Amadini]

Tested that the issue is solved on the latest Nightly on Windows 7.

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4c1c760f05a8

Comment 19

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to :Paolo Amadini from comment #17)
> Tested that the issue is solved on the latest Nightly on Windows 7.

Great! Thanks a lot.

Comment 20

[Paul Silaghi, QA [:pauly]]

Verified fixed FX 50b7, Win 7.