Closed
Bug 1292614
Opened 8 years ago
Closed 8 years ago
Imported modules have introduction type 'scriptElement'
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
|
5.48 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
nbp pointed out that nsScriptLoader::FillCompileOptionsForRequest always sets the introduction type to 'scriptElement' even for imported modules.
|
Assignee | |
Comment 1•8 years ago
|
||
Patch to set the introduction type of imported modules to 'importedModule'. Top-level modules are left with type 'scriptElement'.
Attachment #8781982 -
Flags: review?(bugs)
|
||
Comment 2•8 years ago
|
||
Which spec defines all this stuff?
|
|
||
Comment 3•8 years ago
|
||
er, this is all Gecko internal.
|
|
||
Updated•8 years ago
|
Attachment #8781982 -
Flags: review?(bugs) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/72f943bf1109 Set introductionType correctly for imported modules r=smaug
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/72f943bf1109
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•