Closed Bug 1292628 Opened 5 years ago Closed 5 years ago

Crash in ssse3_fetch_bilinear_cover


(Core :: Graphics, defect)

49 Branch
Windows 7
Not set



Tracking Status
firefox49 + fixed
firefox50 + fixed
firefox51 --- fixed


(Reporter: marcia, Assigned: jrmuizel)


(Keywords: crash, regression)

Crash Data


(1 file)

This bug was filed from the Socorro interface and is 
report bp-9029f4cc-3301-4663-bd95-48bcd2160805.

Seen while looking at beta crash stats: Crash seems to be unique to beta.

ni on jeff since it appears he may have worked in this area of code.
Flags: needinfo?(jmuizelaar)
[Tracking Requested - why for this release]: This is a crash regression during video playback that we should be able to avoid.
Assignee: nobody → jmuizelaar
Flags: needinfo?(jmuizelaar)
Keywords: regression
Version: 48 Branch → 49 Branch
204 crashes in the last week with beta 3. Nothing showing up for beta 4 yet. There's also one crash on 50 aurora.
It looks like most of these have 'Unknown cairo format -1'.
Attachment #8783094 - Flags: review?(mstange) → review+
Pushed by
Make sure our surface is good before locking it. r=mstange
Backed out for failing to create surface in non-e10s reftests on Windows 7 VM:

Push with failures:
Failure log:

17:51:43     INFO - REFTEST TEST-START | file:///c:/slave/test/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/writing-modes-3/text-combine-upright-compression-006a.html == file:///c:/slave/test/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/writing-modes-3/text-combine-upright-compression-006-ref.html
17:51:43     INFO - REFTEST TEST-LOAD | file:///c:/slave/test/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/writing-modes-3/text-combine-upright-compression-006a.html | 1774 / 13765 (12%)
17:51:43     INFO - ++DOMWINDOW == 43 (18B9F400) [pid = 3420] [serial = 7471] [outer = 0DC49400]
17:51:44     INFO - [GFX3-]: DrawTargetSkia(0C66F940): Failure to create source surface from data. Size: Size(800,1000)
17:51:44     INFO - JavaScript error: chrome://reftest/content/reftest.jsm, line 1463: NS_ERROR_FAILURE:
17:51:44     INFO - JavaScript error: chrome://reftest/content/reftest-content.js, line 1090: TypeError: ret is undefined
17:56:43     INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///c:/slave/test/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/writing-modes-3/text-combine-upright-compression-006a.html | load failed: timed out waiting for test to complete (waiting for onload scripts to complete)
Flags: needinfo?(jmuizelaar)
Pushed by
Make sure our surface is good before locking it. r=mstange
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Comment on attachment 8783094 [details] [diff] [review]
Check the error status of a surface before returning the data inside it

Approval Request Comment
[Feature/regressing bug #]: 1292628
[User impact if declined]: Possible crash in ssse3 code
[Describe test coverage new/current, TreeHerder]: Has been on nightly for a very short time.
[Risks and why]: Very low risk, but may just push the problem further down the line.
Attachment #8783094 - Flags: approval-mozilla-beta?
Attachment #8783094 - Flags: approval-mozilla-aurora?
Comment on attachment 8783094 [details] [diff] [review]
Check the error status of a surface before returning the data inside it

I see a lot of crash instances on Beta49 (none on Aurora or Nightly) but given the one-line change, it's worth uplifting to Aurora50 and Beta49.
Attachment #8783094 - Flags: approval-mozilla-beta?
Attachment #8783094 - Flags: approval-mozilla-beta+
Attachment #8783094 - Flags: approval-mozilla-aurora?
Attachment #8783094 - Flags: approval-mozilla-aurora+
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.