1292633 - Make Ctrl+Tab panel background more opaque

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[Dão Gottwald [:dao]]

Attachment: patch

The panel's current background works well in average situations, but in high contrast mode I noticed that certain color combinations in the web content can be pretty distracting behind the panel.

Comment 1

[Mike de Boer [:mikedeboer]]

Comment on attachment 8778384 [details] [diff] [review]
patch

Review of attachment 8778384 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not really aware of the percentage-based rgb notation being commonly used, so I thought you'd take this opportunity to change it to real values.
If possible, can you do that?

Comment 2

[Dão Gottwald [:dao]]

Certainly possible, but for made-up values rather than colors exported from a graphics editor, I prefer percentages over a 255-based scale where I need to start calculating to get my 33% gray tone for instance.

We have no rule for this and use pretty much all available notations all over the place. If we were to create a rule, I'd lobby for HSL and just avoid RGB and HEX notations altogether.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d54bb89e78af
Make Ctrl+Tab panel background more opaque. r=mdeboer

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d54bb89e78af

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8778384 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1116787
[User impact if declined]: see comment 0. bug 1116787 is in the release notes, so this feature will get more attention. would be nice to have it polished.
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: trivial adjustment of a few CSS colors, basically no risk
[String/UUID change made/needed]: none

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5648449ab916
followup, use hsl instead of rgb color notation

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5648449ab916

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8778384 [details] [diff] [review]
patch

CSS only, low risk, Aurora50+

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6b7a77c7ecaa