1292675 - Autoclassify UI doesn't do the "exceeded max bug suggestions" thing, making it really really hard to scroll through.

Status: RESOLVED INVALID

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

When there are a lot of suggestions returned from the api, the Failure summary panel doesn't show them, because it's likely not finding anything useful among all of the false positives.

The Autoclassification panel does no such thing, sometimes showing *lots* of suggestions for each line.

The failure summary panel caps suggestions at 20, maybe the autoclassify panel should do the same?

Comment 1

[James Graham [:jgraham]]

This is somewhat intentional because philor complained about cases where the correct bug was hidden by default, leading to frequent misstarring. I have an idea for sorting the bugs better; maybe once this is implemented it will work to hide some by default.

Comment 2

[Phil Ringnalda (:philor)]

There are at least two things (possibly more) that failure summary does with suggestions, and those are two separate ones.

One thing it does is for failures where there are some open-active suggestions and some closed-inactive suggestions, it shows the open-active ones and puts the closed-inactive ones behind a "Show more" link. That's the use case that bug 1268330 tried to address, by just showing all of them.

Another thing it does is for failures where there are more than 20 open-active suggestions, one of the most common currently seen being a crash [@ mozalloc_abort(const char*)] without a match on the filename so the "successful" bug search is the signature search, it does not show any suggestions, rightly concluding that if what you have is "PROCESS-CRASH | netwerk/test/unit_ipc/test_event_sink_wrap.js | application crashed [@ mozalloc_abort(char const*)]" then no good can come from showing you the 81 open "mozalloc_abort(char const*) kw:intermittent" bugs about a crash with the same meaningless signature in other tests, much less the 146 open-and-closed ones. That thing is what this bug is about, the fact that offering no suggestions is a better UX than offering the crash signature suggestions for https://treeherder.allizom.org/#/jobs?repo=mozilla-inbound&revision=f126e84caf09d45c2eebc9ae33579023ef7e8a47&autoclassify&filter-searchStr=5ed091a8ca66405c84ecedee167ce6720926872d

Comment 3

[James Graham [:jgraham]]

So my plan here is to, in the client, try to do some kind of token match on the summary line and the bug suggestion, and order the matches according to the degree of overlap. Then I could cut off in some way e.g. after 10 or when the goodness of match gets below some threshold value, or something.

Comment 4

[Cameron Dawson [:camd]]

AutoclassifyTab has been removed from the app.