1292696 - ubuntu1604-test fails to build due to libgl1-mesa-dri version mismatch

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Gregory Szorc [:gps]]

I am currently unable to build the ubuntu1604-test image due to a version mismatch in libgl1-mesa-dri. system-setup.sh is expecting version 11.2.0-1ubuntu2. However, the latest Ubuntu package database wants to install 11.2.0-1ubuntu2.1. Chalk up another non-deterministic image build issue :/

I'm not sure why we want this package version pinned. The only reference I could find is bug 1281179 comment #10.

jmaher: it looks like you know what's going on. Can you please weigh in?

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

I pinned it because it worked, I honestly didn't know what I was doing- just trying to get things going.  If we do adjust the version, please test the existing jobs which currently run with 16.04 :)

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1292696 - Pin various graphics related packages to known good versions;

Without this pinning, the image doesn't build deterministically and
fails the version checks that were previously in this file. At the
time this was written, the libgl1-mesa packages were on version
11.2.0-1ubuntu2.1 upstream and building the Docker image locally
failed because these versions would get installed.

A risk to pinning is we'll drift out of date with the OS we're testing
and won't detect failures on packages users in the wild are running.
But on the flip side, automation will be able to build the image
reliably and there won't be "random" failures due to automation
picking up new package versions.

Review commit: https://reviewboard.mozilla.org/r/69792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69792/

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8778495 [details]
Bug 1292696 - Pin various graphics related packages to known good versions;

https://reviewboard.mozilla.org/r/69792/#review66912

this seems much more stable and we can file bugs to upgrade the libraries as we see fit!

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8778495 [details]
Bug 1292696 - Pin various graphics related packages to known good versions;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69792/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0809927f1e16
Pin various graphics related packages to known good versions; r=jmaher

Comment 6

[Gregory Szorc [:gps]]

I backed this out because it somehow resulted in dozens of packages getting *removed* during the `apt-get install` for the libgl packages.

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c891bc425e26
Backed out changeset 0809927f1e16

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

dpkg is strange magic...

Comment 9

[Gregory Szorc [:gps]]

I removed the version checks altogether and pushed to Try. https://treeherder.mozilla.org/#/jobs?repo=try&revision=e62236c9718641299fde866edff5c516648ec650

It looks green aside from some known test failures. So, uh, I think 11.2.0-1ubuntu2.1 is an acceptable package version.

Perhaps we should just remove the version check. This won't be deterministic. But it will find failures with people running the latest stable packages offered by Ubuntu.

Comment 10

[Gregory Szorc [:gps]]

Attachment: Bug 1292696 - Remove version checks for libxcb and libgl;

Pinning these packages breaks Ubuntu package management because
other packages we install explicitly require a newer version.
Attempting to pin these results in packages getting removed or refusal
to install.

Review commit: https://reviewboard.mozilla.org/r/70380/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70380/

Comment 11

[Gregory Szorc [:gps]]

Comment on attachment 8779396 [details]
Bug 1292696 - Remove version checks for libxcb and libgl;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/70380/diff/1-2/

Comment 12

[Andrew Halberstadt [:ahal]]

Comment on attachment 8779396 [details]
Bug 1292696 - Remove version checks for libxcb and libgl;

https://reviewboard.mozilla.org/r/69790/#review67712

Lgtm

Comment 13

[Andrew Halberstadt [:ahal]]

Comment on attachment 8779396 [details]
Bug 1292696 - Remove version checks for libxcb and libgl;

https://reviewboard.mozilla.org/r/70380/#review67714

Lgtm

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5746ddb617c4
Remove version checks for libxcb and libgl; r=ahal

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5746ddb617c4