Closed
Bug 1292727
Opened 9 years ago
Closed 9 years ago
Consolidate context menu navigation icon styling
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
Details
Attachments
(1 file, 1 obsolete file)
24.27 KB,
patch
|
Paolo
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8778518 -
Flags: review?(paolo.mozmail)
Assignee | ||
Comment 1•9 years ago
|
||
Turns out this can be simplified further.
Attachment #8778518 -
Attachment is obsolete: true
Attachment #8778518 -
Flags: review?(paolo.mozmail)
Attachment #8778519 -
Flags: review?(paolo.mozmail)
Comment 2•9 years ago
|
||
Comment on attachment 8778519 [details] [diff] [review]
patch v2
Review of attachment 8778519 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/themes/shared/contextmenu.inc.css
@@ +13,5 @@
> + height: 16px;
> + margin: 7px;
> + filter: url(chrome://browser/skin/filters.svg#fill);
> + fill: currentColor;
> +}
Looks great! Thanks for this unification.
::: browser/themes/windows/content-contextmenu.svg
@@ -1,4 @@
> -<?xml version="1.0"?>
> -<!-- This Source Code Form is subject to the terms of the Mozilla Public
> - - License, v. 2.0. If a copy of the MPL was not distributed with this
> - - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
Please use "hg mv" on one of the platform files so we can keep track of the origin of the shapes using hg blame, or link this bug to bug 1016405.
Attachment #8778519 -
Flags: review?(paolo.mozmail) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5734f8d9f39c
Consolidate context menu navigation icon styling. r=paolo
Comment 4•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in
before you can comment on or make changes to this bug.
Description
•