Closed Bug 1292728 Opened 4 years ago Closed 4 years ago
_safe _browsing _initial _download .py Test Safe Browsing Initial Download .test _safe _browsing _initial _download | Timeout Exception: Timed out after 25 .1 seconds with message: Safe Browsing File: mozstd-track-digest256 .cache not found!
Bug 1292728 - Disable test_safe_browsing_initial_download.py due to perma failures caused by bug 1258041.
58 bytes, text/x-review-board-request
Fix broken test test_safe_browsing_initial_download.py after the recent safebrowsing list changes (bug 1292728).
58 bytes, text/x-review-board-request
Panos, with the landing of your changes on bug 1258041 you broke our safebrowsing tests permanently. Can you please update the test so it reflects the current behavior of Firefox? I would suggest you do try builds in the future to check if changes do not break tests. Thanks.
can we fix this asap please, thanks!
Comment on attachment 8778860 [details] Bug 1292728 - Disable test_safe_browsing_initial_download.py due to perma failures caused by bug 1258041. https://reviewboard.mozilla.org/r/69988/#review67158
Attachment #8778860 - Flags: review?(ato) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f0c07fbbb4b5 Disable test_safe_browsing_initial_download.py due to perma failures caused by bug 1258041. r=ato
What's required to make these SB tests run in tier-1 (so the commit gets backed out, instead of -urrrgh- the test getting disabled)?
They will never become tier-1 because we rely on remote test data for this test. This is strictly forbidden for tier-1 level tests.
Assignee: nobody → past
Status: NEW → ASSIGNED
Priority: -- → P1
This should be enough to fix the test. Let's see if try agrees: https://treeherder.mozilla.org/#/jobs?repo=try&revision=09531223be4d
Try was green and I verified that the test finished successfully. I updated the patch to enable the test again.
Comment on attachment 8779319 [details] Fix broken test test_safe_browsing_initial_download.py after the recent safebrowsing list changes (bug 1292728). https://reviewboard.mozilla.org/r/70322/#review67666 Thanks! ::: testing/firefox-ui/tests/functional/security/test_safe_browsing_initial_download.py:33 (Diff revision 2) > "goog-unwanted-shavar.sbstore", > > # Tracking Protections > - "mozstd-track-digest256.cache", > - "mozstd-track-digest256.pset", > - "mozstd-track-digest256.sbstore", > + "base-track-digest256.cache", > + "base-track-digest256.pset", > + "base-track-digest256.sbstore", Would you mind triggering a try build on linux64 for firefox-ui-functional-remote(-e10s) only? I would like the test passing before we land it.
Attachment #8779319 - Flags: review?(hskupin) → review+
(In reply to Panos Astithas [:past] from comment #15) > Try was green and I verified that the test finished successfully. I updated > the patch to enable the test again. The try build you ran was before you enabled the test, so it has not been executed! Please do it again.
(In reply to Henrik Skupin (:whimboo) from comment #17) > The try build you ran was before you enabled the test, so it has not been > executed! Please do it again. That's not correct, the test was enabled in my tree as the disabling patch hadn't landed in fx-team at that time. You can confirm this by looking for the test name in the raw test output.
Oh, in this case go ahead and land it. Thanks for clarifying, given that it was not clear.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/f38875b13ca3 Fix broken test test_safe_browsing_initial_download.py after the recent safebrowsing list changes . r=whimboo
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
The patch on bug 1258041 got backported to mozilla-aurora now, but this fix has not been incorporated! :( We need to get this onto aurora ASAP to stop the perma orange. Thanks.
You need to log in before you can comment on or make changes to this bug.