1292747 - Remove the 565 optimization from imgFrame

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

The results in bug 1281680 suggest that the 565 optimization in imgFrame is not useful. Since it's not benefiting users, having something like this sticking around in the tree with little or no test coverage is a very bad idea. Let's rip it out.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: (Part 1) - Remove 565 optimization telemetry.

This part removes the telemetry added in bug 1281680. It has served its purpose.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Attachment: (Part 2) - Remove the 565 optimization from imgFrame.

This part removes the optimization itself.

Comment 3

[Seth Fowler [:seth] [:s2h]]

Attachment: (Part 3) - Clean up some comments in imgFrame related to Optimize()'s behavior.

I noticed there are a couple of less-than-stellar comments related to
imgFrame::Optimize(). Let's clean them up.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d3d22827170
(Part 1) - Remove 565 optimization telemetry. r=edwin
https://hg.mozilla.org/integration/mozilla-inbound/rev/253ca6b47c8f
(Part 2) - Remove the 565 optimization from imgFrame. r=edwin
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fcf01a3984e
(Part 3) - Clean up some comments in imgFrame related to Optimize()'s behavior. r=edwin

Comment 5

[Seth Fowler [:seth] [:s2h]]

Thanks for the reviews, Edwin!

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1d3d22827170
https://hg.mozilla.org/mozilla-central/rev/253ca6b47c8f
https://hg.mozilla.org/mozilla-central/rev/5fcf01a3984e