Closed Bug 1292747 Opened 3 years ago Closed 3 years ago

Remove the 565 optimization from imgFrame

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(3 files)

The results in bug 1281680 suggest that the 565 optimization in imgFrame is not useful. Since it's not benefiting users, having something like this sticking around in the tree with little or no test coverage is a very bad idea. Let's rip it out.
This part removes the telemetry added in bug 1281680. It has served its purpose.
Attachment #8778539 - Flags: review?(edwin)
This part removes the optimization itself.
Attachment #8778540 - Flags: review?(edwin)
I noticed there are a couple of less-than-stellar comments related to
imgFrame::Optimize(). Let's clean them up.
Attachment #8778541 - Flags: review?(edwin)
Pushed by seth.bugzilla@blackhail.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d3d22827170
(Part 1) - Remove 565 optimization telemetry. r=edwin
https://hg.mozilla.org/integration/mozilla-inbound/rev/253ca6b47c8f
(Part 2) - Remove the 565 optimization from imgFrame. r=edwin
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fcf01a3984e
(Part 3) - Clean up some comments in imgFrame related to Optimize()'s behavior. r=edwin
Thanks for the reviews, Edwin!
You need to log in before you can comment on or make changes to this bug.