|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
Crash dereferencing a null pointer to a surface in SetFrameCapture, because the CopySurface call in WillRefresh returned null. I am not familiar with this code so I'm not sure if the WillRefresh is responsible for not producing null pointers or if we should handle this gracefully lower down the stack, or something else. Andreas, any idea?
I think we should just avoid calling SetFrameCapture() when CopySurface() returns nullptr. I'll get to it in a bit.
Comment on attachment 8781993 [details] Bug 1292786 - Don't SetFrameCapture() when CopySurface() fails. https://reviewboard.mozilla.org/r/72292/#review69884
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/828e9a557da4 Don't SetFrameCapture() when CopySurface() fails. r=nical