If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Intermittent dom/canvas/test/test_capture.html | application crashed [@ mozilla::dom::HTMLCanvasElement::SetFrameCapture(already_AddRefed<mozilla::gfx::SourceSurface>)]

RESOLVED FIXED in Firefox 51

Status

()

Core
Canvas: 2D
RESOLVED FIXED
a year ago
9 months ago

People

(Reporter: Treeherder Bug Filer, Assigned: pehrsons)

Tracking

({intermittent-failure})

unspecified
mozilla51
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
treeherder
Filed by: phil [at] philringnalda.com

https://treeherder.mozilla.org/logviewer.html#?job_id=33173570&repo=mozilla-inbound

http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win64/1470067249/mozilla-inbound_win8_64_test-mochitest-1-bm127-tests1-windows-build1204.txt.gz
Crash dereferencing a null pointer to a surface in SetFrameCapture, because the CopySurface call in WillRefresh returned null. I am not familiar with this code so I'm not sure if the WillRefresh is responsible for not producing null pointers or if we should handle this gracefully lower down the stack, or something else.
Andreas, any idea?
Flags: needinfo?(pehrson)
Whiteboard: [gfx-noted]
(Assignee)

Comment 2

a year ago
I think we should just avoid calling SetFrameCapture() when CopySurface() returns nullptr.

I'll get to it in a bit.
Assignee: nobody → pehrson
Flags: needinfo?(pehrson)
(Assignee)

Updated

a year ago
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8781993 [details]
Bug 1292786 - Don't SetFrameCapture() when CopySurface() fails.

https://reviewboard.mozilla.org/r/72292/#review69884
Attachment #8781993 - Flags: review?(nical.bugzilla) → review+

Comment 5

a year ago
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/828e9a557da4
Don't SetFrameCapture() when CopySurface() fails. r=nical

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/828e9a557da4
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
(Assignee)

Updated

9 months ago
Duplicate of this bug: 1324815
You need to log in before you can comment on or make changes to this bug.