Closed Bug 1293000 Opened 4 years ago Closed 4 years ago

Replace in-tree consumer of non-standard Iterator() with Object.entries in layout/

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: arai, Assigned: andrewtawf, Mentored)

References

Details

(Whiteboard: [good first bug] [lang=js])

Attachments

(1 file)

separated from bug 1290637.
see bug 1290637 for the details.

Required code changes are following:
  * Replace usage of non-standard Iterator [1] function with Object.entries [2]

There is only one usage in layout/
https://dxr.mozilla.org/mozilla-central/source/layout/style/test/bug453896_iframe.html#37
>   for (let [feature, value] in
>          Iterator({ "width": width_val, "height": height_val })) {
>     should_apply("all and (" + feature + ": " + value + "px)");
>     should_not_apply("all and (" + feature + ": " + (value + 1) + "px)");
>     should_not_apply("all and (" + feature + ": " + (value - 1) + "px)");
>   }

it should be changed to use for-of and Object.entries.


[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator
[2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries
Hi I would like to work on this bug. This is my first bug.
Thank you for taking this :)

If you have any question related to the fix, building, and testing, feel free to ask here, or ping me (:arai) in IRC #introduction channel
Attached patch mypatch.diffSplinter Review
Attachment #8779347 - Flags: review?(arai.unmht)
Comment on attachment 8779347 [details] [diff] [review]
mypatch.diff

Review of attachment 8779347 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for your patch :)
Looks good.
Forwarding to bz, as I'm not a module owner/peer here.
Attachment #8779347 - Flags: review?(bzbarsky)
Attachment #8779347 - Flags: review?(arai.unmht)
Attachment #8779347 - Flags: feedback+
Comment on attachment 8779347 [details] [diff] [review]
mypatch.diff

r=me
Attachment #8779347 - Flags: review?(bzbarsky) → review+
It passed try run.
Assignee: nobody → andrewtawf
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43f446ee8c82
Replace Iterator() with Object.entries() in layout/. r=bz
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/43f446ee8c82
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.