129305 - No headers and attachments are displayed when open in a New Mail window

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[marina]

**** observed with 2002-02-06 build ****
This bug is visible when you open a new mail window (not to confuse with opening
a message in a new window, this works)
Steps to reproduce:
- select an account or folder in the left pane, rightclick and chose "Open in a
New Mail window";
//note that the new mail window is open;
- now select a message and observe that the message body has no headres and in
case there was an attachment it won't be shown either

Comment 1

[laurel]

Using mar6 commercial trunk: all platforms
nominating and marking as regression - problem not present in mar5 build

Comment 2

[scottputterman]

reassigning to ssu.  this sounds similar to the standalone message window bug
that was fixed.

Comment 3

[Håkan Waara]

Spooky... The header-pane is completely hidden, as if it was not loaded, in the
new 3pane.

Comment 4

[Sean Su]

The console is also throwing up lots of the following errors:
  JavaScript strict warning:
chrome://messenger/content/msgMail3PaneWindow.js line 480: reference to
undefined property window.arguments[0].QueryInterface

I trace it down to Bienvenu's patch to fix bug:
  http://bugzilla.mozilla.org/show_bug.cgi?id=112105 - Clicking on a folder link
should allow subscribing to shared folder

I simply reverted part of his patch (see below):

    //need to add to session before trying to load start folder otherwise
listeners aren't
    //set up correctly.
    if ("arguments" in window && window.arguments[0])
    {
 -    param = window.arguments[0].QueryInterface(
Components.interfaces.nsIDialogParamBlock  );
 -    if( !param )
 -      dump( " error getting param block interface\n" );
 -
 -    gStartFolderUri = param.GetString( 0 ) ;
 -    gStartMsgKey = param.GetInt( 0 );
 +    gStartFolderUri = window.arguments[0].uri;
 +    gStartMsgKey = window.arguments[0].key;
    }
    else
    {
      gStartFolderUri = null;
      gStartMsgKey = -1;
    }

The above code is in msgMail3PaneWindow.js' OnLoadMessenger() function.  It
seemed to have fixed this bug.  I'm reassigning this bug to David because I
don't know about his patch, and reverting this will most likely cause other
problems elsewhere.

ps. reverting the above code also fixes the problem that when opening a 2nd
mailnews window by double clicking on a folder, the folder does not get loaded
in the thread pane.

Comment 5

[David :Bienvenu]

The fix is probably to change the js that opens the folder pane window in that
case.  Looking.

Comment 6

[David :Bienvenu]

Attachment: proposed fix

use the dialog param block like the c++ code does - this is the only instance I
could find of this type of window getting opened from js. Sean, please review.

Comment 7

[Sean Su]

Comment on attachment 74001 [details] [diff] [review]
proposed fix

r=ssu

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 74001 [details] [diff] [review]
proposed fix

sr=sspitzer

Comment 9

[Sean Su]

*** Bug 130846 has been marked as a duplicate of this bug. ***

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 74001 [details] [diff] [review]
proposed fix

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 11

[David :Bienvenu]

fix checked in.

Comment 12

[David :Bienvenu]

*** Bug 131272 has been marked as a duplicate of this bug. ***

Comment 13

[laurel]

OK using mar18 commercial trunk: win98, linux rh6.2, mac OS 9.2
OK for both opening a folder in new window from context menu and from Go To
Folder in search messages.