Signins from the synced-tabs pane should get a unique "entrypoint" value

RESOLVED FIXED in Firefox 49

Status

()

Firefox
Sync
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: rfkelly, Assigned: markh)

Tracking

unspecified
Firefox 51
Points:
---

Firefox Tracking Flags

(firefox48 wontfix, firefox49 fixed, firefox50 fixed, firefox51 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

a year ago
STR:

* Start a profile that's not logged in to sync
* Click on the "synced tabs" toolbar button; since no devices are connected you should get a "sign in the sync" solicitation
* Click on "sign in to sync"

Actual Result:

You wind up at the sync preferences pane with entrypoint=uitour:

   about:preferences?entrypoint=uitour#sync


Expected Result:

You should get a unique entrypoint= value indicating that you came from the synced tabs page, something like:

  about:preferences?entrypoint=synced-tabs#sync


See also https://github.com/mozilla/fxa-auth-server/issues/1390
(Assignee)

Updated

a year ago
Blocks: 1293181
(Assignee)

Comment 1

a year ago
I'm making thus bug just track that "syncbutton" is used instead of "synced-tabs" - I opened bug 1293181 to track that sometimes "uitour" overrides the specified entry-point when it apparently should not.
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8778770 [details]
Bug 1293128 - use an appropriate entry-point when opening about:accounts via the SyncedTabs menu.

https://reviewboard.mozilla.org/r/69934/#review67238

LGTM
Attachment #8778770 - Flags: review?(eoger) → review+

Updated

a year ago
Priority: -- → P1
(Assignee)

Updated

a year ago
Assignee: nobody → markh

Comment 4

a year ago
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/autoland/rev/368638f47657
use an appropriate entry-point when opening about:accounts via the SyncedTabs menu. r=eoger
(Assignee)

Updated

a year ago
status-firefox48: --- → wontfix
status-firefox49: --- → affected
status-firefox50: --- → affected
(Assignee)

Comment 5

a year ago
Comment on attachment 8778770 [details]
Bug 1293128 - use an appropriate entry-point when opening about:accounts via the SyncedTabs menu.

Approval Request Comment
[Feature/regressing bug #]: Synced Tabs menu
[User impact if declined]: We will have trouble collecting metrics on how many users sign up for a Sync account via the Synced Tabs menu
[Describe test coverage new/current, TreeHerder]: Existing tests pass
[Risks and why]: Very low risk, trivial patch
[String/UUID change made/needed]: None

This is a simple patch I think we should take as far as we can. Not taking for beta is not the end of the world, but the risk is low enough I believe it's probably worthwhile.
Attachment #8778770 - Flags: approval-mozilla-beta?
Attachment #8778770 - Flags: approval-mozilla-aurora?
Backed out in https://hg.mozilla.org/integration/autoland/rev/e4751138f043 for https://treeherder.mozilla.org/logviewer.html#?job_id=1613776&repo=autoland
(Assignee)

Updated

a year ago
Attachment #8778770 - Attachment is obsolete: true
Attachment #8778770 - Flags: approval-mozilla-beta?
Attachment #8778770 - Flags: approval-mozilla-aurora?

Comment 7

a year ago
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/fx-team/rev/d8d09f4544be
use an appropriate entry-point when opening about:accounts via the SyncedTabs menu. r=eoger
(Assignee)

Comment 8

a year ago
Created attachment 8779595 [details] [diff] [review]
0001-Bug-1293128-use-an-appropriate-entry-point-when-open.patch

This is the patch I relanded after pushing a try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8ceeceaf20a

Approval Request Comment
[Feature/regressing bug #]: Synced Tabs menu
[User impact if declined]: We will have trouble collecting metrics on how many users sign up for a Sync account via the Synced Tabs menu
[Describe test coverage new/current, TreeHerder]: Existing tests pass (for real this time!)
[Risks and why]: Very low risk, trivial patch
[String/UUID change made/needed]: None

This is a simple patch I think we should take as far as we can. Not taking for beta is not the end of the world, but the risk is low enough I believe it's probably worthwhile.
Attachment #8779595 - Flags: review+
Attachment #8779595 - Flags: approval-mozilla-beta?
Attachment #8779595 - Flags: approval-mozilla-aurora?
status-firefox51: --- → affected

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d8d09f4544be
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Comment on attachment 8779595 [details] [diff] [review]
0001-Bug-1293128-use-an-appropriate-entry-point-when-open.patch

We want better data on sync and the ui tour; ok to uplift to beta.
Attachment #8779595 - Flags: approval-mozilla-beta?
Attachment #8779595 - Flags: approval-mozilla-beta+
Attachment #8779595 - Flags: approval-mozilla-aurora?
Attachment #8779595 - Flags: approval-mozilla-aurora+

Comment 11

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/b74c428d8c96
status-firefox50: affected → fixed

Comment 12

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/5f8667738b0b
status-firefox49: affected → fixed
You need to log in before you can comment on or make changes to this bug.