Mediasource Object URLs should start with 'blob'

RESOLVED FIXED in Firefox 50

Status

defect
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: bryce, Assigned: bryce)

Tracking

49 Branch
mozilla51
All
Unspecified
Dependency tree / graph

Firefox Tracking Flags

(firefox49 wontfix, firefox50 fixed, firefox51 fixed)

Details

Attachments

(1 attachment)

As part of https://bugzilla.mozilla.org/show_bug.cgi?id=1279493 media source URLs now start with 'blob', not 'mediasource'. This has caused breakages inside playback/youtube/test_basic_playback.py::test_mse_is_enabled_by_default which expect the old behaviour.
This behaviour changed as part of Bug 1279493, and the tests should be updated
to reflect this.

Review commit: https://reviewboard.mozilla.org/r/69896/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69896/
Attachment #8778737 - Flags: review?(dburns)
Assignee: nobody → bvandyk
Hardware: Unspecified → All
Blocks: 1288499
Comment on attachment 8778737 [details]
Bug 1293149 - Mediasource URL check should check for 'blob' instead of 'mediasource'.

https://reviewboard.mozilla.org/r/69896/#review67128
Attachment #8778737 - Flags: review?(dburns) → review+
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f431fe83f56a
Mediasource URL check should check for 'blob' instead of 'mediasource'. r=automatedtester
https://hg.mozilla.org/mozilla-central/rev/f431fe83f56a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Comment on attachment 8778737 [details]
Bug 1293149 - Mediasource URL check should check for 'blob' instead of 'mediasource'.

Approval Request Comment
[Feature/regressing bug #]:  Bug 1293149 + Bug 1288499
[User impact if declined]: Failures of external media tests (https://developer.mozilla.org/en-US/docs/Mozilla/QA/external-media-tests) for Aurora branch.
[Describe test coverage new/current, TreeHerder]: Addresses failures in the external media tests due to changes made in bug 1279493.
[Risks and why]: Low risk. Small and simple code change. Could break external media tests. Even in this case no direct impact would be had on end users.
[String/UUID change made/needed]: None.
Attachment #8778737 - Flags: approval-mozilla-aurora?
Comment on attachment 8778737 [details]
Bug 1293149 - Mediasource URL check should check for 'blob' instead of 'mediasource'.

Automation test changes are auto-approved. These do not need relman review.
Attachment #8778737 - Flags: approval-mozilla-aurora?
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.