1293175 - [Pointer Event] Add Element.hasPointerCapture API

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Ming-Chou Shih [:stone]]

Add new API to Element interface

partial interface Element {
  boolean hasPointerCapture (long pointerId);


Reference
https://github.com/w3c/pointerevents/issues/121

Comment 1

[Ming-Chou Shih [:stone]]

Attachment: Bug 1293175 - [Pointer Event] Add Element.hasPointerCapture API (V1)

Comment 2

[Ming-Chou Shih [:stone]]

Attachment: Bug 1293175 - [Pointer Event] Add Element.hasPointerCapture API (V2)

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8779965 [details] [diff] [review]
Bug 1293175 - [Pointer Event] Add Element.hasPointerCapture API (V2)

Review of attachment 8779965 [details] [diff] [review]:
-----------------------------------------------------------------

f=me after the following issue is addressed, thanks!

::: dom/events/test/pointerevents/test_pointerevent_element_haspointercapture.html
@@ +18,5 @@
> +        iframe.src = "pointerevent_element_haspointercapture.html";
> +      }
> +      function executeTest(int_win) {
> +        sendMouseEvent(int_win, "target0", "mousemove");
> +        sendMouseEvent(int_win, "target0", "mousedown", {button:0, buttons:1});

property of "buttons" looks meaningless according the usage in defined in sendMouseEvent in mochitest_support_external.js.
Please remove it if not used.

@@ +19,5 @@
> +      }
> +      function executeTest(int_win) {
> +        sendMouseEvent(int_win, "target0", "mousemove");
> +        sendMouseEvent(int_win, "target0", "mousedown", {button:0, buttons:1});
> +        sendMouseEvent(int_win, "target0", "mousemove", {button:0, buttons:1});

ditto

@@ +20,5 @@
> +      function executeTest(int_win) {
> +        sendMouseEvent(int_win, "target0", "mousemove");
> +        sendMouseEvent(int_win, "target0", "mousedown", {button:0, buttons:1});
> +        sendMouseEvent(int_win, "target0", "mousemove", {button:0, buttons:1});
> +        sendMouseEvent(int_win, "target1", "mousemove", {button:0, buttons:1});

ditto

@@ +21,5 @@
> +        sendMouseEvent(int_win, "target0", "mousemove");
> +        sendMouseEvent(int_win, "target0", "mousedown", {button:0, buttons:1});
> +        sendMouseEvent(int_win, "target0", "mousemove", {button:0, buttons:1});
> +        sendMouseEvent(int_win, "target1", "mousemove", {button:0, buttons:1});
> +        sendMouseEvent(int_win, "target1", "mouseup", {button:0, buttons:1});

ditto

Comment 4

[Ming-Chou Shih [:stone]]

Attachment: Bug 1293175 - [Pointer Event] Add Element.hasPointerCapture API (V3)

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8779994 [details] [diff] [review]
Bug 1293175 - [Pointer Event] Add Element.hasPointerCapture API (V3)

>+                        assert_equals(target0.hasPointerCapture(e.pointerId), false,
>+                                      "before target0.setPointerCapture, target0.hasPoineterCapture should be false")
hasPoineterCapture  -> hasPointerCapture
Same also elsewhere.


Why to have the same test twice? wpt tests should be enough, assuming we run them automatically. Please explain.

Comment 6

[Ming-Chou Shih [:stone]]

The wpt tests in testing\web-platform\tests\pointerevents are synchronized with wpt tests on github. These pointer event tests can't be run automatically because they need to be triggered by user inputs. I think the tests in dom\events\test\pointerevents are copied from testing\web-platform\tests\pointerevents and wrapped by corresponding mochitest tests which synthesize input events. So I add tests to both folders. Please let me know if any suggestions. Thanks.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

ok, thanks for reminding about that. so,two tests for now.

Comment 8

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2063df35509ba11746a3fd50cd596227b4463ea

Comment 9

[Ming-Chou Shih [:stone]]

Attachment: Bug 1293175 - [Pointer Event] Add Element.hasPointerCapture API (V4)

Fixed typo and updated the patch summary

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb4b9ceaaa02
[Pointer Event] Add Element.hasPointerCapture API. r=smaug

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fb4b9ceaaa02

Comment 12

[Boris Zbarsky [:bzbarsky]]

This patch didn't add the web platform test to the manifest, so it's not actually being run.....

Comment 13

[Ming-Chou Shih [:stone]]

Yes, I missed it, so another bug1296194 is created to add it. BTW, it can't be run as web platform tests because it needs to be triggered by user inputs. We wrap it and run it as mochitests. The wrappers and tests are in dom/events/test/pointerevents

Comment 14

[Rick Byers]

Thanks for adding the new test!  See some discussion upstream here: https://github.com/w3c/web-platform-tests/pull/3566