Broken HTML in translation string

NEW
Unassigned

Status

()

Firefox for Android
General
P3
normal
2 years ago
3 months ago

People

(Reporter: stoyan, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [TPE-1])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The entity is "malformedURI.longDesc2" and the HTML content of it is not valid HTML. The error from the validator is "Element div not allowed as child of element ul in this context."
(Reporter)

Updated

2 years ago
Blocks: 1042199
(Reporter)

Comment 1

2 years ago
Entity "dnsNotFound.longDesc4" is broken the same way.
Priority: -- → P1
Whiteboard: [TPE-1]

Comment 2

2 years ago
This seems to have been added in 2014 in Bug 1042199:
https://hg.mozilla.org/mozilla-central/rev/a4b979000940

I'm slightly worried that changing this would cause translation churn.
Comment hidden (mozreview-request)

Comment 4

2 years ago
The patch I've uploaded would seem to fix this (based on playing around with the w3 validator), however I haven't tested in a local build yet.

As mentioned I'm worried about the translation churn, especially seeing as the current code works despite being non-compliant - do we want to continue with this?
Let's bring in flod to understand if updating this string is a problem.


(In reply to Andrzej Hunt :ahunt from comment #4)
> The patch I've uploaded would seem to fix this (based on playing around with
> the w3 validator), however I haven't tested in a local build yet.

Okay, we should make sure that everything's working correctly by just triggering this error page. And we should try to keep the indentation correct/clean. :)
Flags: needinfo?(francesco.lodolo)
Delphine owns mobile l10n, it's her decision ;-)

Updating the string would require localizers to "re-translate" it, since the source changes. The point to evaluate is: how bad is to have broken HTML in an internal page (not exposed to other browsers, and working as expected in Firefox)?
Flags: needinfo?(francesco.lodolo) → needinfo?(lebedel.delphine)
Thanks for forwarding flod. I think it makes sense to correct this
Flags: needinfo?(lebedel.delphine)
Can you take care of getting this tested and landed?
Flags: needinfo?(ahunt)
The patch as it is it's not OK: if you want other locales to fix the HTML you will need a new string ID.
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

That's unless we don't care about locales keeping the broken HTML.
Flags: needinfo?(ahunt)
Comment hidden (obsolete)
[triage] Given engineering resources, only critical bugs will remain P1.
Keywords: stale-bug
Priority: P1 → P3
You need to log in before you can comment on or make changes to this bug.