1293226 - Broken HTML in translation string

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Stoyan Dimitrov [:stoyan]]

The entity is "malformedURI.longDesc2" and the HTML content of it is not valid HTML. The error from the validator is "Element div not allowed as child of element ul in this context."

Comment 1

[Stoyan Dimitrov [:stoyan]]

Entity "dnsNotFound.longDesc4" is broken the same way.

Comment 2

[Andrzej Hunt :ahunt]

This seems to have been added in 2014 in Bug 1042199:
https://hg.mozilla.org/mozilla-central/rev/a4b979000940

I'm slightly worried that changing this would cause translation churn.

Comment 3

[Andrzej Hunt :ahunt]

Attachment: Bug 1293226 - Make netError content html-spec compliant

Review commit: https://reviewboard.mozilla.org/r/73618/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73618/

Comment 4

[Andrzej Hunt :ahunt]

The patch I've uploaded would seem to fix this (based on playing around with the w3 validator), however I haven't tested in a local build yet.

As mentioned I'm worried about the translation churn, especially seeing as the current code works despite being non-compliant - do we want to continue with this?

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Let's bring in flod to understand if updating this string is a problem.


(In reply to Andrzej Hunt :ahunt from comment #4)
> The patch I've uploaded would seem to fix this (based on playing around with
> the w3 validator), however I haven't tested in a local build yet.

Okay, we should make sure that everything's working correctly by just triggering this error page. And we should try to keep the indentation correct/clean. :)

Comment 6

[Francesco Lodolo [:flod]]

Delphine owns mobile l10n, it's her decision ;-)

Updating the string would require localizers to "re-translate" it, since the source changes. The point to evaluate is: how bad is to have broken HTML in an internal page (not exposed to other browsers, and working as expected in Firefox)?

Comment 7

[Delphine Lebédel [:delphine - use need info]]

Thanks for forwarding flod. I think it makes sense to correct this

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Can you take care of getting this tested and landed?

Comment 9

[Francesco Lodolo [:flod]]

The patch as it is it's not OK: if you want other locales to fix the HTML you will need a new string ID.
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

That's unless we don't care about locales keeping the broken HTML.

Comment 10

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is a P1 bug without an assignee. 

P1 are bugs which are being worked on for the current release cycle/iteration/sprint. 

If the bug is not assigned by Monday, 28 August, the bug's priority will be reset to '--'.

Comment 11

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

[triage] Given engineering resources, only critical bugs will remain P1.

Comment 12

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 13

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.