Closed Bug 1293234 Opened 4 years ago Closed 4 years ago

Use octal notation for permission modes in the build system

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox51 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file)

Use octal notation for permission modes in the build system
7.09 KB, patch
gps
: review+
Details | Diff | Splinter Review 
As of Python 3, decimal notations of octal values for permission modes
are no longer permitted and will result in a `SyntaxError` exception
(`invalid token`).

Using the proper octal notation which is also Python 2.7 compatible will
fix this issue.
Component: Audio/Video → Build Config
Comment on attachment 8778846 [details] [diff] [review]
Use octal notation for permission modes in the build system

Review of attachment 8778846 [details] [diff] [review]:
-----------------------------------------------------------------

Nice cleanup. Thanks.
Attachment #8778846 - Flags: review?(gps) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c5103b41449
Use octal notation for permission modes in the build system; r=gps
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9c5103b41449
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.