Closed
Bug 1293234
Opened 9 years ago
Closed 9 years ago
Use octal notation for permission modes in the build system
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox51 fixed)
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
7.09 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
As of Python 3, decimal notations of octal values for permission modes
are no longer permitted and will result in a `SyntaxError` exception
(`invalid token`).
Using the proper octal notation which is also Python 2.7 compatible will
fix this issue.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8778846 -
Flags: review?(gps)
|
|
Assignee | |
Updated•9 years ago
|
Component: Audio/Video → Build Config
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8778846 [details] [diff] [review]
Use octal notation for permission modes in the build system
Review of attachment 8778846 [details] [diff] [review]:
-----------------------------------------------------------------
Nice cleanup. Thanks.
Attachment #8778846 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c5103b41449
Use octal notation for permission modes in the build system; r=gps
Keywords: checkin-needed
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•