Closed
Bug 1293234
Opened 6 years ago
Closed 6 years ago
Use octal notation for permission modes in the build system
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox51 fixed)
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
7.09 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
As of Python 3, decimal notations of octal values for permission modes are no longer permitted and will result in a `SyntaxError` exception (`invalid token`). Using the proper octal notation which is also Python 2.7 compatible will fix this issue.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8778846 -
Flags: review?(gps)
Assignee | ||
Updated•6 years ago
|
Component: Audio/Video → Build Config
Comment 2•6 years ago
|
||
Comment on attachment 8778846 [details] [diff] [review] Use octal notation for permission modes in the build system Review of attachment 8778846 [details] [diff] [review]: ----------------------------------------------------------------- Nice cleanup. Thanks.
Attachment #8778846 -
Flags: review?(gps) → review+
Assignee | ||
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=620bcaf77deffa957625712d299f8d96fd4023f2
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9c5103b41449 Use octal notation for permission modes in the build system; r=gps
Keywords: checkin-needed
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9c5103b41449
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Updated•4 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•