Reftests produce broken structured logs

RESOLVED FIXED in Firefox 51

Status

Testing
Reftest
P1
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: jgraham, Unassigned)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Reftests are producing structured logs without any information in the "message" field, making autoclassify fail.
Comment hidden (mozreview-request)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8779817 [details]
Bug 1293250 - Make reftest log generation less magical,

https://reviewboard.mozilla.org/r/70734/#review68508

Lgtm, just need some clarification on id_str.

::: layout/tools/reftest/output.py
(Diff revision 1)
>              if status != "PASS":
>                  status_msg += "KNOWN-"
>              status_msg += status
>              if extra.get('status_msg') == 'Random':
>                  status_msg += "(EXPECTED RANDOM)"
> -        test = self.id_str(data['test'])

Why did you remove id_str? Does this mean the log will look like:
TEST-UNEXPECTED-FAIL | ('file1', '==', 'file2)' | ..

That seems kind of ugly, or am I missing something?
Attachment #8779817 - Flags: review?(ahalberstadt) → review+
(Reporter)

Comment 5

2 years ago
mozreview-review-reply
Comment on attachment 8779817 [details]
Bug 1293250 - Make reftest log generation less magical,

https://reviewboard.mozilla.org/r/70734/#review68508

> Why did you remove id_str? Does this mean the log will look like:
> TEST-UNEXPECTED-FAIL | ('file1', '==', 'file2)' | ..
> 
> That seems kind of ugly, or am I missing something?

No, there are no tuple ids anymore, so it's not needed.

Comment 6

2 years ago
mozreview-review-reply
Comment on attachment 8779817 [details]
Bug 1293250 - Make reftest log generation less magical,

https://reviewboard.mozilla.org/r/70734/#review68508

> No, there are no tuple ids anymore, so it's not needed.

Thanks for clarifying, this looks good then!

Comment 7

2 years ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/4ad88cfd05b5
Make reftest log generation less magical, r=ahal

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4ad88cfd05b5
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Depends on: 1342252
You need to log in before you can comment on or make changes to this bug.