1293287 - Popups should be closed when extensions shutdown

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect, P1)

Description

[devunion]

Attachment: BrowserAction bug.png

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.82 Safari/537.36

Steps to reproduce:

Steps to reproduce the issue: 
1. Install sample extension from https://bugzilla.mozilla.org/show_bug.cgi?id=1293282 ticket.
2. Open popup.
3. Press Reload Button to reload the extension.


Actual results:

Previously loaded popup is not removed completely (See attached screenshot. There is just small arrow visible, but one time I was able to see full popup in this location.)


Expected results:

HTML popup should be completely removed after reloading.

Comment 2

[devunion]

I've reported this bug separately because I think that it is related to another part of functionality. 
The bug 1293282 related to functionality of the poup itself while this one is related to the functionality of the Reload button.

If we have auto hide option disabled (I assume that this is correct state of the system), then Reload button should work as expected and the popup should be completely removed.

Comment 3

[Kris Maglione [:kmag]]

I guess we could handle this a bit better.

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1293287: Close extension popups on extension shutdown.

Review commit: https://reviewboard.mozilla.org/r/73966/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73966/

Comment 5

[Andrew Swan [:aswan]]

Comment on attachment 8784615 [details]
Bug 1293287: Close extension popups on extension shutdown.

https://reviewboard.mozilla.org/r/73966/#review72108

::: browser/components/extensions/test/browser/browser_ext_popup_shutdown.js:34
(Diff revision 1)
> +      },
> +    });
> +  };
> +
> +  {
> +    info("Test stand-alone browserAction popup");

just curious why you do this this way rather than adding 3 separate tasks with descriptively named functions (which mochitest will helpfully print)

Comment 6

[Kris Maglione [:kmag]]

Comment on attachment 8784615 [details]
Bug 1293287: Close extension popups on extension shutdown.

https://reviewboard.mozilla.org/r/73966/#review72108

> just curious why you do this this way rather than adding 3 separate tasks with descriptively named functions (which mochitest will helpfully print)

No particular reason. This is just what the test I copied it from looked like.

Comment 7

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c79543918cee752a50ce9c351d3ad15b72b658e8
Bug 1293287: Close extension popups on extension shutdown. r=aswan

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c79543918cee

Comment 9

[CosminB]

I could not reproduce this issue on Firefox 51.0a1 (20160801074053) or Firefox 52.0a1 (20161003030438), [e-mail] could you confirm that the bug is fixed on:
http://archive.mozilla.org/pub/firefox/nightly/2016/10/2016-10-04-00-40-06-mozilla-aurora/firefox-51.0a2.en-US.win64.zip