1293339 - Popup window for "Share this page" button shouldn't be autohide (or should restore inputted text when the panel is reopened for same tab)

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: SocialAPI, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The popup window for "Share this page" button is specified as autohide in current build. However, it's not useful and there are no reasonable reasons.

First of all, the reason why most popup XUL <panel> should be autohide is that if it's a top-most window, there may not be a way to close it. In such case, top-most window in OS level may block other applications' UI. However, we can provide a close button for it, and on non-Linux platforms, the popup is NOT a top-most window. So, if we add a close button to the popup, we don't worry about this security issue.

Then, I'm in trouble in some pages, when I want to share a page and I want to paste two or more separated text in the page to the message, I cannot do it because when I move focus to the page for selecting text, the popup is closed by autohide behavior.

So, I'd be happy if the popup isn't autohide and has close button for Linux.
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/panel.noautohide

Comment 1

[:Gijs (he/him)]

Shane, thoughts?

(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #0)
> The popup window for "Share this page" button is specified as autohide in
> current build. However, it's not useful and there are no reasonable reasons.
> 
> First of all, the reason why most popup XUL <panel> should be autohide is
> that if it's a top-most window, there may not be a way to close it. In such
> case, top-most window in OS level may block other applications' UI. However,
> we can provide a close button for it, and on non-Linux platforms, the popup
> is NOT a top-most window. So, if we add a close button to the popup, we
> don't worry about this security issue.

Well, we'd also need to hide it if another window or application is focused (certainly on Linux, because the panel will be always-on-top), if the user switches tabs, ... there are a lot of edgecases to consider if it isn't "autohide", and you're basically suggesting that they are less important than your usecase. I think that is not necessarily true.

Comment 2

[Shane Caraveo (:mixedpuppy)]

I don't see where noautohide is being set at all.

https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#253

Comment 3

[Shane Caraveo (:mixedpuppy)]

ie. afaik the share panel has default behavior.

Comment 4

[:Gijs (he/him)]

(In reply to Shane Caraveo (:mixedpuppy) from comment #3)
> ie. afaik the share panel has default behavior.

Yes, the request is for it to *not* be autohidden by default, ie to *add* the "noautohide" flag.

Comment 5

[Shane Caraveo (:mixedpuppy)]

But wouldn't that make the share panel behave different than other panels?

Comment 6

[Shane Caraveo (:mixedpuppy)]

ie. I don't get it.  If default behavior is a problem with the share panel, it is a problem with all panels and the default should change.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to :Gijs Kruitbosch (PTO recovery mode) from comment #1)
> Shane, thoughts?
> 
> (In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #0)
> > The popup window for "Share this page" button is specified as autohide in
> > current build. However, it's not useful and there are no reasonable reasons.
> > 
> > First of all, the reason why most popup XUL <panel> should be autohide is
> > that if it's a top-most window, there may not be a way to close it. In such
> > case, top-most window in OS level may block other applications' UI. However,
> > we can provide a close button for it, and on non-Linux platforms, the popup
> > is NOT a top-most window. So, if we add a close button to the popup, we
> > don't worry about this security issue.
> 
> Well, we'd also need to hide it if another window or application is focused
> (certainly on Linux, because the panel will be always-on-top), if the user
> switches tabs, ... there are a lot of edgecases to consider if it isn't
> "autohide", and you're basically suggesting that they are less important
> than your usecase. I think that is not necessarily true.

Yes, that's difficult point.

(In reply to Shane Caraveo (:mixedpuppy) from comment #6)
> ie. I don't get it.  If default behavior is a problem with the share panel,
> it is a problem with all panels and the default should change.

The reason why current panel for "Share this page" is not enough to work well like the other panel is, users may input too complicated text on auto-hide panel.

In other words, when it's hidden automatically, user may want to restart to input. If the button stores inputted text until the tab is closed (or until active tab is switched) and the text is restored when the panel is reopened, it's enough to me.

Comment 8

[:Gijs (he/him)]

We removed the share panel.