1293357 - Add in code coverage patch

Status: RESOLVED WONTFIX

(WebExtensions :: General, defect, P3)

Description

[Andy McKay]

In bug 1288808 we want to auto generate the code coverage for WebExtensions. It would be nice if we had the patch land in the tree so that we don't need to keep it up to date and catch any regressions when they land.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1293357: Add code coverage tests for WebExtensions.

Review commit: https://reviewboard.mozilla.org/r/109388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109388/

Comment 2

[Andy McKay]

Hmm, what should we do with this one aswan? I suspect it can no longer be merged.

Comment 3

[Andrew Swan [:aswan]]

Yeah, sorry for leaving this one in limbo for so long, I suspect its quite bit-rotted at this point.
I don't remember if there were other issues but the main one is that I think the ignore annotations are going to be very difficult to maintain (and they're atrociously ugly too).
I don't have any better ideas off the top of my head, perhaps we could have a wider discussion about this?  eg a broadcast to firefox-dev to find out what other groups are doing?  I'd be willing to do that unless Kris wants to...

Comment 4

[Andy McKay]

I think we should see if we can get some general Firefox solution here instead of our own home grown one. Thanks for sending that email to firefox-dev, that's a good start.