1293397 - Run mach taskgraph python-tests more often

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

This job keeps failing in unrelated pushes because it doesn't get run in the push that did not update the tests.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0329537bee24225608e30e865ea44dfa9d9aa6a9
Bug 1293397: fix fake to make tests pass? r=armenzg

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

https://hg.mozilla.org/mozilla-central/rev/34cefe01d821 has a diffstat including

  taskcluster/docs/attributes.rst
  taskcluster/taskgraph/create.py
  taskcluster/taskgraph/target_tasks.py 

which should match

  taskgraph-tests:
    task: tasks/tests/taskgraph-tests.yml
    root: true
    when:
      file_patterns:
        - 'taskcluster/**.py'
        - 'config/mozunit.py'
        - 'python/mach/**.py'

yet

  https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=62a983c56050&filter-searchStr=tg

is empty.

The decision task log lists this change:

https://public-artifacts.taskcluster.net/OVtZYD5DREi9ypz4OPFZRQ/0/public/logs/live_backing.log
...
[task 2016-08-04T13:58:05.131337Z] "GET /mozilla-central/json-automationrelevance/62a983c56050b3ac647d8f95d9c2ca69c3ad2d91 HTTP/1.1" 200 None
[task 2016-08-04T13:58:05.779116Z] 29 commits influencing task scheduling:
...
[task 2016-08-04T13:58:05.781198Z] 34cefe01d821 Bug 1279676 - Support --rebuild try flag to schedule tests N times. r=dustin
...

yet

...
[task 2016-08-04T13:58:05.835130Z] discarding tasks/tests/taskgraph-tests.yml because no relevant files changed
...

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

>>> from mozpack.path import match as mozpackmatch
>>> mozpackmatch("taskcluster/foo/bar.py", "taskcluster/**.py")
False

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1293397: run taskgraph-tests when things change;

This fixes the use of the bogus pattern `taskcluster/**.py` which does not
actually match python files in subdirectories.

Review commit: https://reviewboard.mozilla.org/r/70116/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70116/

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8779067 [details]
Bug 1293397: run taskgraph-tests when things change;

https://reviewboard.mozilla.org/r/70116/#review67364

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8df38f8ada3
run taskgraph-tests when things change; r=gps

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a8df38f8ada3

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0329537bee24